Conversation
…rces Replace the chain of FilterController extenders with a list of filter sources. Every module that contributes to the data filter — the filter row, the header filter, the search panel and the filter sync — now implements `getFilterExpressions` on its own controller, and FilterController asks the sources in a fixed order instead of being extended by each of them. Along the way the suppression windows of the filter sync become explicit: `suspendColumnSources` covers the whole "column option -> filterValue" step, because column options are updated in a batch and the column sources still report the previous filter until the batch ends, while `withColumnOptionsSync` covers only the mirroring back into the column options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.