remove inlines form react datagrid demos - #35128
Open
DuckTieCorpMember wants to merge 2 commits into
Open
Conversation
| </DataGrid> | ||
| ); | ||
| const DetailGrid = ({ data: detail }: { data: DataGridTypes.MasterDetailTemplateData }) => { | ||
| const detailDataSource = getDetailGridDataSource(detail.data); |
Contributor
There was a problem hiding this comment.
wrap in useMemo, please
| </Summary> | ||
| </DataGrid> | ||
| ); | ||
| const DetailGrid = ({ data: detail }: { data: DataGridTypes.MasterDetailTemplateData }) => { |
Contributor
There was a problem hiding this comment.
We use this component as prop, lets wrap it with memo - it would be useful to wrap other custom components with props in memo, but it can wait
Suggested change
| const DetailGrid = ({ data: detail }: { data: DataGridTypes.MasterDetailTemplateData }) => { | |
| import { memo } from 'react'; | |
| const DetailGrid = memo(({ data: detail }: { data: DataGridTypes.MasterDetailTemplateData }) => { |
Co-authored-by: Anna Shakhova <68295572+anna-shakhova@users.noreply.github.com> Signed-off-by: assylbek.danyshbek <assylbek.danyshbek@devexpress.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes through DataGrid and CardView React demos and replaces inlines with objects and functions