DataGrid - AI Assistant: Disable chat suggestions in disabled state#33587
Open
Alyar666 wants to merge 2 commits into
Open
DataGrid - AI Assistant: Disable chat suggestions in disabled state#33587Alyar666 wants to merge 2 commits into
Alyar666 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DataGrid AI Assistant chat integration to ensure the Chat suggestions (ButtonGroup) widget is disabled/enabled together with the AIChat disabled state, aligning suggestions behavior with the already-disabled input, speech-to-text, and clear button.
Changes:
- Added a
CLASSES.chatSuggestionsselector for the Chat suggestions container. - Extended
AIChat.setDisabled()to disable/enable the Chat suggestions widget instance. - Added Jest coverage for disabling/enabling suggestions when the element is present.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/ai_chat/const.ts |
Adds a class constant for locating the chat suggestions element. |
packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.ts |
Disables/enables the suggestions ButtonGroup when AIChat is disabled/enabled. |
packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.test.ts |
Adds unit tests for toggling suggestions disabled state. |
469baff to
d5810c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.