Skip to content

AI Assistant: Integration leftovers#33585

Open
dmirgaev wants to merge 3 commits into
DevExpress:26_1from
dmirgaev:26_1__ai_assistant_leftovers
Open

AI Assistant: Integration leftovers#33585
dmirgaev wants to merge 3 commits into
DevExpress:26_1from
dmirgaev:26_1__ai_assistant_leftovers

Conversation

@dmirgaev
Copy link
Copy Markdown
Contributor

No description provided.

@dmirgaev dmirgaev self-assigned this May 14, 2026
Copilot AI review requested due to automatic review settings May 14, 2026 19:00
@dmirgaev dmirgaev requested a review from a team as a code owner May 14, 2026 19:00
@dmirgaev dmirgaev added the 26_1 label May 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up leftovers from the AI Assistant integration: it consolidates the getGridExtraContext/getGridColumnExtraContext extension hooks into direct buildContext/buildColumnContext overrides, caches controller references, removes stale TODOs, and adds extensive test coverage including a new DataGrid integration test file.

Changes:

  • Refactor AIAssistantIntegrationController to cache dataController/columnsController and replace the "extra context" hooks with overridable buildContext/buildColumnContext methods.
  • Remove stale // TODO comments and unneeded as unknown as test casts.
  • Significantly expand Jest coverage for AI assistant controllers (failure paths, headerText formatting, dispose behavior, second-request rejection) and add new DataGrid integration controller test file.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/index.ts Removed obsolete TODO comment.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_integration_controller.ts Cached controller refs; replaced extra-context hooks with overridable buildContext/buildColumnContext.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_integration_controller.integration.test.ts Dropped unnecessary as unknown cast in test setup.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_controller.test.ts Added tests for failure paths, header formatting, dispose, and request rejection.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/index.ts Removed obsolete TODO comment.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/ai_assistant_integration_controller.ts Switched DataGrid overrides to new buildContext/buildColumnContext API.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/tests/ai_assistant_integration_controller.integration.test.ts New integration test file for DataGrid AI assistant controller.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/tests/ai_assistant_controller.test.ts New unit tests for DataGridAIAssistantController.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants