Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ef78a4a
Remove the usage of exec for variable cases
dxvladislavvolkov May 11, 2026
e7ace91
Refactoring
dxvladislavvolkov May 12, 2026
777fb61
Merge branch '26_1' into fix-lint
dxvladislavvolkov May 12, 2026
6b3d9a7
Fix for Windows
dxvladislavvolkov May 12, 2026
fb3908a
Merge branch 'fix-lint' of https://github.com/dxvladislavvolkov/DevEx…
dxvladislavvolkov May 12, 2026
edbcb36
Merge branch '26_1' into fix-lint
dxvladislavvolkov May 12, 2026
2329b25
Fix bundler for windows
dxvladislavvolkov May 12, 2026
a7b6c98
Merge branch 'fix-lint' of https://github.com/dxvladislavvolkov/DevEx…
dxvladislavvolkov May 12, 2026
74290f1
Merge branch '26_1' into fix-lint
dxvladislavvolkov May 12, 2026
4184da5
Change fix for windows (do not use shell)
dxvladislavvolkov May 12, 2026
203bd95
Merge branch 'fix-lint' of https://github.com/dxvladislavvolkov/DevEx…
dxvladislavvolkov May 12, 2026
2d4e7c6
Revert "Change fix for windows (do not use shell)"
dxvladislavvolkov May 12, 2026
af7ce00
Fix lint
dxvladislavvolkov May 12, 2026
3166c07
Set shell value to true
dxvladislavvolkov May 13, 2026
b89c667
Merge branch '26_1' into fix-lint
dxvladislavvolkov May 13, 2026
5dbbd7a
Use execFile instead of spawn to optimize process
dxvladislavvolkov May 14, 2026
bcbf530
Merge branch 'fix-lint' of https://github.com/dxvladislavvolkov/DevEx…
dxvladislavvolkov May 14, 2026
bc91937
Merge branch '26_1' into fix-lint
dxvladislavvolkov May 14, 2026
80a6447
Merge branch '26_1' into fix-lint
dxvladislavvolkov May 15, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apps/demos/utils/create-bundles/Angular/bundler.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { exec } from 'child_process';
import { spawn } from 'child_process';
import { BuildOptions } from 'esbuild';
import { existsSync, mkdirSync, removeSync } from 'fs-extra';
import { Demo, Framework } from '../helper/types';
Expand Down Expand Up @@ -42,8 +42,7 @@ export default class AngularBundler implements Bundler {

createDemoLayout(demo, this.framework);

const ngBuildCommand = `npm run build-angular -- ${getProjectNameByDemo(demo)}`;
const ngBuildProcess = exec(ngBuildCommand);
const ngBuildProcess = spawn('npm', ['run', 'build-angular', '--', getProjectNameByDemo(demo)], { shell: true });
Comment thread
dxvladislavvolkov marked this conversation as resolved.
ngBuildProcess.stdout.on('data', (data) => {
console.log(`stdout: ${data}`);
});
Expand Down
7 changes: 3 additions & 4 deletions apps/demos/utils/ts-to-js-converter/converter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,8 @@ const pipeSource = async (
}));
};

// eslint-disable-next-line require-await
const execTsc = async (directory: string, args: string): Promise<string> => new Promise((resolve, reject) => {
cps.exec(`tsc ${args}`, (error, stdout, stderr) => {
const execTsc = (directory: string, args: string[]): Promise<string> => new Promise((resolve, reject) => {
cps.execFile('tsc', args, { shell: true, cwd: directory }, (error, stdout, stderr) => {
if (error != null) {
Comment on lines +81 to 83
// eslint-disable-next-line prefer-promise-reject-errors
return reject(`${error}\n${stderr}\n${stdout}`);
Expand Down Expand Up @@ -110,7 +109,7 @@ const compile = async (resolve: PathResolvers, log: Logger) => {
),
);

await execTsc(resolve.source('./'), `--build ${tsconfigFile}`);
await execTsc(resolve.source('./'), ['--build', tsconfigFile]);
};

const copyAssets = async (resolve: PathResolvers, log: Logger) => {
Expand Down
Loading