Skip to content

Rename binary-cache-v8.sqlite to binary-cache-detsys-v1.sqlite - #390

Merged
edolstra merged 1 commit into
mainfrom
rename-nar-info-cache
Mar 18, 2026
Merged

edolstra merged 1 commit into
mainfrom
rename-nar-info-cache

Conversation

@edolstra

@edolstra edolstra commented Mar 18, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

Upstream Nix recently renamed cache to binary-cache-v8 to handle build traces, which collides with our binary-cache-v8 that handles provenance. So let's adopt a unique name.

Context

Summary by CodeRabbit

  • Chores
    • Updated binary cache database configuration naming convention for the cache system.

Upstream Nix recently renamed the cache to binary-cache-v8 to handle
build traces, which collides with our binary-cache-v8 that handles
provenance. So let's adopt a unique name.
@coderabbitai

coderabbitai Bot commented Mar 18, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 635ad407-bbc1-42e2-b348-8e3790102107

📥 Commits

Reviewing files that changed from the base of the PR and between 35a0be5 and 78728c6.

📒 Files selected for processing (1)
  • src/libstore/nar-info-disk-cache.cc

📝 Walkthrough

Walkthrough

The default SQLite database filename for the NarInfoDiskCacheImpl constructor is updated from "binary-cache-v8.sqlite" to "binary-cache-detsys-v1.sqlite". This single-line change alters the default path used to initialize the on-disk cache database without modifying any logic.

Changes

Cohort / File(s) Summary
Database Filename Update
src/libstore/nar-info-disk-cache.cc
Constructor default parameter changed from binary-cache-v8.sqlite to binary-cache-detsys-v1.sqlite.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • cole-h

Poem

🐰 A hop, a skip, a database name change,
From v8 to detsys-v1, oh how things rearrange,
The cache path shifts with a single touch,
Small edits that mean oh-so-much! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: renaming a SQLite database filename from binary-cache-v8.sqlite to binary-cache-detsys-v1.sqlite, which is the sole modification in this changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rename-nar-info-cache
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@edolstra
edolstra enabled auto-merge March 18, 2026 19:50
@github-actions

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request March 18, 2026 20:16 Inactive
@edolstra
edolstra added this pull request to the merge queue Mar 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Mar 18, 2026
@edolstra
edolstra added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 0960be3 Mar 18, 2026
28 checks passed
@edolstra
edolstra deleted the rename-nar-info-cache branch March 18, 2026 23:20

This branch was previously deployed

1 inactive deployment
pull request — 78728c64 Deployed Mar 18, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants