Skip to content

fix: mark the plugin bundle as ESM so it loads on Node 20.0-20.18 and 22.0-22.6 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satsukies merged 1 commit into from
Oct 7, 2026
Merged

fix: mark the plugin bundle as ESM so it loads on Node 20.0-20.18 and 22.0-22.6 #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions plugin/scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"type": "module"
}
9 changes: 9 additions & 0 deletions src/__tests__/plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,15 @@ describe("plugin/.mcp.json", () => {
});
});

describe("plugin/scripts/package.json", () => {
// The plugin cache copies only plugin/, so this file is what makes Node
// load bundle.js as ESM on versions without module syntax detection
// (Node < 20.19 and 22.0-22.6).
it("marks the bundle directory as ESM", () => {
expect(loadJson("plugin/scripts/package.json").type).toBe("module");
});
});

describe("plugin/skills/ (slash commands)", () => {
it("skills/setup/SKILL.md exists", () => {
expect(existsSync(resolve(ROOT, "plugin/skills/setup/SKILL.md"))).toBe(true);
Expand Down
Loading