Skip to content

Remove tabindex from non-interactive scrollbar elements - #1596

Open
moha0993 wants to merge 4 commits into
DependencyTrack:masterfrom
moha0993:fix/remove-scrollbar-tabindex
Open

Remove tabindex from non-interactive scrollbar elements#1596
moha0993 wants to merge 4 commits into
DependencyTrack:masterfrom
moha0993:fix/remove-scrollbar-tabindex

Conversation

@moha0993

@moha0993 moha0993 commented Jun 10, 2026

Copy link
Copy Markdown

Description

Removes tabindex="0" from non-interactive scrollbar elements (.ps__scrollbar-x and .ps__scrollbar-y).

These elements are invisible and do not provide any functionality, but were still receiving keyboard focus, resulting in blank focus stops for users navigating via keyboard or assistive technologies.

Addressed Issue

Closes #1596

Additional Details

The fix removes tabindex from the scrollbar elements using a Vue lifecycle approach, ensuring they are no longer included in the tab order.

This solution ensures that only interactive and meaningful elements remain focusable, improving keyboard navigation and accessibility.

The approach was chosen to avoid modifying third-party library code directly and instead handle the issue within the component lifecycle.

Verified by:

  • Testing keyboard navigation flow:
    Admin → Sidebar Minimizer → Home
  • Confirming removal of blank focus stops
  • Inspecting document.activeElement to ensure only valid interactive elements receive focus

Checklist

@owasp-dt-bot

owasp-dt-bot commented Jun 10, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@moha0993
moha0993 force-pushed the fix/remove-scrollbar-tabindex branch from 8267cf9 to 5088cbc Compare June 10, 2026 13:35
Ubuntu and others added 4 commits June 12, 2026 18:45
Signed-off-by: Ubuntu <ahmedm@ahmed-DT.vojtk5sve0setetrc1omp3vl0h.ux.internal.cloudapp.net>
Signed-off-by: Ahmed Mohamed <ahmedmohamedismael@outlook.com>
Signed-off-by: Ahmed Mohamed <ahmedmohamedismael@outlook.com>
Signed-off-by: Ahmed Mohamed <ahmedmohamedismael@outlook.com>
Signed-off-by: Ahmed Mohamed <ahmedmohamedismael@outlook.com>
@moha0993
moha0993 force-pushed the fix/remove-scrollbar-tabindex branch from 4352e7b to 961a0dd Compare June 12, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants