Remove tabindex from non-interactive scrollbar elements - #1596
Open
moha0993 wants to merge 4 commits into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
moha0993
force-pushed
the
fix/remove-scrollbar-tabindex
branch
from
June 10, 2026 13:35
8267cf9 to
5088cbc
Compare
Signed-off-by: Ubuntu <ahmedm@ahmed-DT.vojtk5sve0setetrc1omp3vl0h.ux.internal.cloudapp.net> Signed-off-by: Ahmed Mohamed <ahmedmohamedismael@outlook.com>
Signed-off-by: Ahmed Mohamed <ahmedmohamedismael@outlook.com>
Signed-off-by: Ahmed Mohamed <ahmedmohamedismael@outlook.com>
Signed-off-by: Ahmed Mohamed <ahmedmohamedismael@outlook.com>
moha0993
force-pushed
the
fix/remove-scrollbar-tabindex
branch
from
June 12, 2026 18:45
4352e7b to
961a0dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes tabindex="0" from non-interactive scrollbar elements (.ps__scrollbar-x and .ps__scrollbar-y).
These elements are invisible and do not provide any functionality, but were still receiving keyboard focus, resulting in blank focus stops for users navigating via keyboard or assistive technologies.
Addressed Issue
Closes #1596
Additional Details
The fix removes tabindex from the scrollbar elements using a Vue lifecycle approach, ensuring they are no longer included in the tab order.
This solution ensures that only interactive and meaningful elements remain focusable, improving keyboard navigation and accessibility.
The approach was chosen to avoid modifying third-party library code directly and instead handle the issue within the component lifecycle.
Verified by:
Admin → Sidebar Minimizer → Home
Checklist