Add SpringX's info to the Yields adapter#2710
Open
TheOfficialSpringX wants to merge 1 commit into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR adds a new SpringX adaptor that retrieves yield and TVL data from SpringX contracts on the Plasma chain. The adaptor fetches pool metadata, calculates USD valuations using external price data, computes scaled APY values, and exports filtered results meeting a minimum TVL threshold. ChangesSpringX Yield Adaptor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The springx adapter exports pools: Test Suites: 1 passed, 1 total |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/adaptors/springx/index.js (1)
16-19: ⚡ Quick winDeduplicate coin keys before calling the prices endpoint.
Duplicate assets across pools create an unnecessarily long URL and extra lookup work. Build
coinsKeyfrom aSetfirst.Proposed change
- let coinsKey = pools.map((pool) => `${chain}:${pool.asset}`); + let coinsKey = [...new Set(pools.map((pool) => `${chain}:${pool.asset.toLowerCase()}`))]; let { coins } = await utils.getData( `https://coins.llama.fi/prices/current/${coinsKey}`, );🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/adaptors/springx/index.js` around lines 16 - 19, The coinsKey built via pools.map includes duplicate asset keys; change construction to deduplicate (e.g., create a Set from pools.map or iterate pools to add `${chain}:${pool.asset}` to a Set) and use the unique keys when calling utils.getData for the prices endpoint (the call that currently passes coinsKey to `https://coins.llama.fi/prices/current/${coinsKey}`), ensuring you convert the Set back into the expected comma-separated string or array form before the request.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/adaptors/springx/index.js`:
- Around line 42-44: The PID comparison in the tvl lookup can fail when
ABI-decoded types differ (string vs number) causing valid pools to be dropped;
in the block using farmToTvls, tvlRows, and tvlInfo (where you call
tvlRows.find(item => item.pid === pool.pid)), normalize types before comparing
(e.g., coerce both item.pid and pool.pid to the same type with Number(...) or
String(...)) so the find matches regardless of ABI decoding differences and
valid pools are not silently filtered out.
- Around line 29-38: The loop that calls api.abi.call for each key (iterating
farmAddresses, setting farmToTvls) must be changed to batched parallel calls to
avoid N+1 RPC latency/timeouts: collect targets from Object.keys(farmAddresses),
split into chunks (e.g., 50), and for each chunk use Promise.all to call
api.abi.call({ target, abi: abi.getTvl, chain }) in parallel, then write results
into farmToTvls[item.toLowerCase()] preserving the same key format;
alternatively, if your SDK exposes a multicall helper, use that with abi.getTvl
to fetch many targets at once and map responses back to farmToTvls. Ensure
errors per-call are handled so one failure doesn’t abort the whole batch.
---
Nitpick comments:
In `@src/adaptors/springx/index.js`:
- Around line 16-19: The coinsKey built via pools.map includes duplicate asset
keys; change construction to deduplicate (e.g., create a Set from pools.map or
iterate pools to add `${chain}:${pool.asset}` to a Set) and use the unique keys
when calling utils.getData for the prices endpoint (the call that currently
passes coinsKey to `https://coins.llama.fi/prices/current/${coinsKey}`),
ensuring you convert the Set back into the expected comma-separated string or
array form before the request.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7d17f725-f1a4-4d67-be7f-c8f9713df3c6
📒 Files selected for processing (1)
src/adaptors/springx/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes