Fix #14623: Add created and updated date filters to ApiRiskAcceptance…#14754
Merged
Maffooch merged 1 commit intoDefectDojo:devfrom Apr 30, 2026
Merged
Conversation
|
This pull request includes a sensitive edit to
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
Comment to provide feedback on these findings.
Report false positive: @dryrunsecurity fp [FINDING ID] [FEEDBACK]
Report low-impact: @dryrunsecurity nit [FINDING ID] [FEEDBACK]
Example: @dryrunsecurity fp drs_90eda195 This code is not user-facing
All finding details can be found in the DryRun Security Dashboard.
Member
|
Could you please rebase against bugfix or dev |
Author
|
Done! Switched the base branch to dev and rebased. |
NasorHidar
force-pushed
the
fix-14623-risk-acceptance-filters
branch
from
7073a63 to
0491c3a
Compare
Maffooch
approved these changes
Apr 30, 2026
…AcceptanceFilter
NasorHidar
force-pushed
the
fix-14623-risk-acceptance-filters
branch
from
87d02f0 to
99e8fd4
Compare
Jino-T
approved these changes
Apr 30, 2026
valentijnscholten
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves Issue #14623.
The
risk_acceptanceAPI endpoint previously returnedcreatedandupdatedtimestamps but lacked the filter query parameters needed by API consumers. This update modifies theApiRiskAcceptanceFilterclass insidedojo/filters.pyto includeDateRangeFilterlogic for both fields, ensuring they support standard DRF date/time lookups (exact,gt,lt,gte,lte), mirroring the setup used in thefindingsfiltersets.Test results
Verified the
django-filtersyntax and dictionary mappings align with existing core model implementations indojo/filters.py. No existing tests were modified.