Skip to content

Set unique_id_from_tool from matrix field in Dependency Track parser #14380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maffooch merged 4 commits into from
Feb 27, 2026
+12 −2
Merged

Set unique_id_from_tool from matrix field in Dependency Track parser #14380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e5e1f9
Set unique_id_from_tool from matrix field in Dependency Track parser
samiat4911 Feb 24, 2026
cb001d6
Merge branch 'dev' into fix/dependency-track-unique-id-from-tool
valentijnscholten Feb 26, 2026
e8ed27e
fix(dependency-track): store matrix as unique_id_from_tool, uuid as v…
valentijnscholten Feb 26, 2026
7d9bf4e
Merge branch 'dev' into fix/dependency-track-unique-id-from-tool
samiat4911 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dojo/tools/dependency_track/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,12 @@ def _convert_dependency_track_finding_to_dojo_finding(self, dependency_track_fin
vulnerability_description += "\nVulnerability Subtitle: {subtitle}".format(subtitle=dependency_track_finding["vulnerability"]["subtitle"])
if "description" in dependency_track_finding["vulnerability"] and dependency_track_finding["vulnerability"]["description"] is not None:
vulnerability_description += "\nVulnerability Description: {description}".format(description=dependency_track_finding["vulnerability"]["description"])
vuln_id_from_tool = None
unique_id_from_tool = dependency_track_finding.get("matrix")
if "uuid" in dependency_track_finding["vulnerability"] and dependency_track_finding["vulnerability"]["uuid"] is not None:
unique_id_from_tool = dependency_track_finding["vulnerability"]["uuid"]
vuln_id_from_tool = dependency_track_finding["vulnerability"]["uuid"]
if "matrix" in dependency_track_finding["vulnerability"] and dependency_track_finding["vulnerability"]["matrix"] is not None:
unique_id_from_tool = dependency_track_finding["vulnerability"]["matrix"]

# Get severity according to Dependency Track and convert it to a severity DefectDojo understands
dependency_track_severity = dependency_track_finding["vulnerability"]["severity"]
Expand Down
9 changes: 8 additions & 1 deletion unittests/tools/test_dependency_track_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def test_dependency_track_parser_has_many_findings(self):
self.assertIsNone(findings[1].unsaved_vulnerability_ids)
self.assertEqual(1, len(findings[2].unsaved_vulnerability_ids))
self.assertEqual("CVE-2016-2097", findings[2].unsaved_vulnerability_ids[0])
self.assertEqual("900991f6-335a-49cb-9bf6-87b545f960ce", findings[2].unique_id_from_tool)
self.assertEqual("8d7f5fcd-210b-491d-a29e-904c2e01b281:3e52f829-3317-48c3-bde1-342c610bd223:900991f6-335a-49cb-9bf6-87b545f960ce", findings[2].unique_id_from_tool)
self.assertEqual("900991f6-335a-49cb-9bf6-87b545f960ce", findings[2].vuln_id_from_tool)
self.assertTrue(findings[2].false_p)
self.assertTrue(findings[2].is_mitigated)
Expand All @@ -56,6 +56,10 @@ def test_dependency_track_parser_has_one_finding(self):
parser = DependencyTrackParser()
findings = parser.get_findings(testfile, Test())
self.assertEqual(1, len(findings))
self.assertEqual(
"ca4f2da9-0fad-4a13-92d7-f627f3168a56:b815b581-fec1-4374-a871-68862a8f8d52:115b80bb-46c4-41d1-9f10-8a175d4abb46",
findings[0].unique_id_from_tool,
)

def test_dependency_track_parser_v3_8_0(self):
with (
Expand All @@ -65,6 +69,7 @@ def test_dependency_track_parser_v3_8_0(self):
findings = parser.get_findings(testfile, Test())
self.assertEqual(9, len(findings))
self.assertTrue(all(item.file_path is not None for item in findings))
self.assertTrue(all(item.vuln_id_from_tool is not None for item in findings))
self.assertTrue(all(item.unique_id_from_tool is not None for item in findings))

def test_dependency_track_parser_findings_with_alias(self):
Expand All @@ -78,6 +83,7 @@ def test_dependency_track_parser_findings_with_alias(self):
self.assertTrue(all(item.file_path is not None for item in findings))
self.assertTrue(all(item.unique_id_from_tool is not None for item in findings))
self.assertTrue(all(item.vuln_id_from_tool is not None for item in findings))
self.assertTrue(all(item.unique_id_from_tool is not None for item in findings))
self.assertIn("CVE-2022-42004", findings[0].unsaved_vulnerability_ids)
self.assertIn("DSA-5283-1", findings[0].unsaved_vulnerability_ids)
self.assertIn("GHSA-rgv9-q543-rqg4", findings[0].unsaved_vulnerability_ids)
Expand All @@ -100,6 +106,7 @@ def test_dependency_track_parser_findings_with_cvssV3_score(self):
self.assertTrue(all(item.file_path is not None for item in findings))
self.assertTrue(all(item.unique_id_from_tool is not None for item in findings))
self.assertTrue(all(item.vuln_id_from_tool is not None for item in findings))
self.assertTrue(all(item.unique_id_from_tool is not None for item in findings))
self.assertIn("CVE-2022-42004", findings[0].unsaved_vulnerability_ids)
self.assertEqual(8.3, findings[0].cvssv3_score)

Expand Down