updates to github workflows#14179
Closed
dogboat wants to merge 1 commit intoDefectDojo:locationsfrom
Closed
Conversation
…pass along this as envvar to testing containers
dogboat
commented
Jan 27, 2026
| # no celery or initializer needed for unit tests | ||
| - name: Unit tests | ||
| timeout-minutes: 20 | ||
| timeout-minutes: 25 |
Contributor
Author
There was a problem hiding this comment.
I don't think this change is necessary anymore. We can drop it down again if you'd like and change it back if necessary.
Contributor
There was a problem hiding this comment.
Does not hurt to keep it imo
Contributor
Author
|
The failing linter issues have been resolved in the other PR, we can wait for that to be merged in and I'll update accordingly. |
Contributor
Author
|
Closing this one, changes here will be part of the mondo pr instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates some of the github workflows to run all tests (UI/integration and unittests) with locations both enabled and disabled.
Well, "all." Some will be skipped. Herein, the endpoint_test integration test is explicitly skipped when locations are enabled as the functionality it tests no longer exists. Additionally, subsequent PRs will include changes to unittests that skip some functionality, but it'll be handled within the class or as a decorator on it.
Big thanks to Val for having given me a pattern to follow in his pghistory work, and to Cody for directing me to that.