Fix FileUpload.copy() to prevent title length exceeding 100 chars#13968
Merged
Maffooch merged 1 commit intoDefectDojo:bugfixfrom Dec 29, 2025
Merged
Conversation
3 tasks
mtesauro
reviewed
Dec 24, 2025
Fixes DefectDojo#11314 When copying a FileUpload, the copy() method appends ' - clone-{hash}' (17 characters) to the title without checking if it would exceed the database max_length constraint of 100 characters. This causes a DataError when copying tests with files that have long names. The fix truncates the original title before appending the clone suffix to ensure the total length never exceeds 100 characters.
35065da to
03e1c39
Compare
Maffooch
approved these changes
Dec 25, 2025
blakeaowens
approved these changes
Dec 27, 2025
Jino-T
approved these changes
Dec 29, 2025
Maffooch
pushed a commit
to valentijnscholten/django-DefectDojo
that referenced
this pull request
Feb 16, 2026
…fectDojo#13968) Fixes DefectDojo#11314 When copying a FileUpload, the copy() method appends ' - clone-{hash}' (17 characters) to the title without checking if it would exceed the database max_length constraint of 100 characters. This causes a DataError when copying tests with files that have long names. The fix truncates the original title before appending the clone suffix to ensure the total length never exceeds 100 characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if we want to keep the copy functionality, but here's a quick fix for Fixes #11314
Problem
When copying a Test with attached files, the copy operation fails with a database error if any file has a title that is 84+ characters long. The error occurs because the
FileUpload.copy()method appends- clone-{hash}(17 characters) to the title without checking if it would exceed the databasemax_lengthconstraint of 100 characters.Solution
Modified the
copy()method inFileUploadto truncate the original title before appending the clone suffix, ensuring the total length never exceeds 100 characters.Changes
Testing
Error Before Fix
After Fix
File titles are properly truncated to fit within the 100 character limit, allowing tests to be copied successfully with all attached files.