Skip to content

feat(broker): Add start-up checker#13931

Merged
valentijnscholten merged 1 commit intoDefectDojo:bugfixfrom
kiblik:broker_checker
Dec 22, 2025
Merged

feat(broker): Add start-up checker#13931
valentijnscholten merged 1 commit intoDefectDojo:bugfixfrom
kiblik:broker_checker

Conversation

@kiblik
Copy link
Copy Markdown
Contributor

@kiblik kiblik commented Dec 18, 2025

I have seen a DD instance that looked ok (no failed containers), but in fact, it wasn't operating correctly. As soon as valkey (or other Redis-compatible instance) is not available during the startup of the component that needs it (apply to celery* + uwsgi; do not apply to initializer), we need to wait (or fail, as it takes too long).

Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
@kiblik kiblik marked this pull request as ready for review December 19, 2025 21:59
Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@valentijnscholten valentijnscholten added this to the 2.53.4 milestone Dec 20, 2025
Copy link
Copy Markdown
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we also should switch to service_healthy instead of service_started (in general)

@Maffooch Maffooch requested a review from rossops December 22, 2025 07:27
@valentijnscholten valentijnscholten merged commit 6ced1de into DefectDojo:bugfix Dec 22, 2025
150 checks passed
@kiblik kiblik deleted the broker_checker branch December 22, 2025 12:28
Maffooch pushed a commit to valentijnscholten/django-DefectDojo that referenced this pull request Feb 16, 2026
Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants