perf: Use lazy loading for Product_Tab to improve edit finding performance Fixes#10313

[Vincent-Ngobeh]

Summary

Refactored Product_Tab class in dojo/utils.py to use @cached_property decorators for lazy loading instead of executing all database queries eagerly in __init__. This significantly improves page load performance for views like Edit Finding.

Related Issue: Fixes #10313

Problem

When editing a finding in a product with 100,000+ findings, the page takes 50+ seconds to load. This is because Product_Tab.__init__ executes 5+ expensive COUNT queries immediately, even though the Edit Finding page doesn't need all of them.

Solution

• Replace eager query execution with @cached_property decorators
• Queries are now deferred until actually accessed
• Results are cached for the duration of the request

Key changes:

• Add functools.cached_property import
• Convert engagement_count, open_findings_count, endpoints_count, endpoint_hosts_count, and benchmark_type to @cached_property
• Rename internal attributes to use underscore prefix (_product, _title, etc.)
• Convert title, tab, product, engagement to @property for consistency

Test Plan

• Verified syntax with python -m py_compile dojo/utils.py
• Verified no flake8 errors in changed code
• Template access patterns remain compatible (properties accessible same way)

Checklist

• Rebased against latest dev
• Code is flake8 compliant
• Code is Python 3.13 compliant
• Meaningful PR title for release notes
• Added unit tests (existing tests cover template access patterns)

[dryrunsecurity]

🔴 Risk threshold exceeded.

This pull request modifies a sensitive file path (dojo/utils.py) flagged by the scanner for potentially sensitive edits; repository owners can configure sensitive paths and allowed authors in .dryrunsecurity.yaml to adjust blocking behavior.

🔴 Configured Codepaths Edit in dojo/utils.py

Vulnerability	Configured Codepaths Edit
Description	Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.

We've notified @mtesauro.

---

All finding details can be found in the DryRun Security Dashboard.

[valentijnscholten]

wow, I've never seen this code. I don't think we should keep this in this way as we have predefined queries for what is meant by "Open" findings etc. But for now there's no harm in merging this to make it more "lazy" :-)

[valentijnscholten]

@Vincent-Ngobeh If you want you can rebase the fix onto bugfix so we can release it sooner. Leaving it as-is is also fine by me.

[Maffooch]

Agreed with everything Val said. Excellent job!

[mtesauro]

Approved