Skip to content

[Docs] Changes Group.Read.All to GroupMember.Read.All in docs#13800

Closed
dcfSec wants to merge 1 commit intoDefectDojo:bugfixfrom
dcfSec:bugfix
Closed

[Docs] Changes Group.Read.All to GroupMember.Read.All in docs#13800
dcfSec wants to merge 1 commit intoDefectDojo:bugfixfrom
dcfSec:bugfix

Conversation

@dcfSec
Copy link
Copy Markdown

@dcfSec dcfSec commented Dec 1, 2025

Description

This PR changes the recommended Entra Id API permission from Group.Read.All to GroupMember.Read.All. The reason for this is that with Group.* permission the application can also access MS Teams APIs (see here. For least privileges it is better to use the GroupMember.Read.All permission. This permission still allows to read basic group properties and group member (see here) but prevents the application from reading e.g., Teams chats or shared files.

  • Group.Read.All: "Allows the app to list groups, and to read their properties and all group memberships on behalf of the signed-in user. Also allows the app to read calendar, conversations, files, and other group content for all groups the signed-in user can access."
  • GroupMember.Read.All: "Allows the app to list groups, read basic group properties and read membership of all groups the signed-in user has access to."

@github-actions github-actions Bot added the docs label Dec 1, 2025
@dcfSec dcfSec changed the title Changes Group.Read.All to GroupMember.Read.All in docs [Docs] Changes Group.Read.All to GroupMember.Read.All in docs Dec 1, 2025
@mtesauro mtesauro requested a review from paulOsinski December 1, 2025 20:02
Copy link
Copy Markdown
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than asserting the usage of GroupMember.Read.All over Group.Read.All I think it would be preferable to add a note explaining why GroupMember.Read.All can be used in place of Group.Read.All

@dcfSec
Copy link
Copy Markdown
Author

dcfSec commented Dec 3, 2025

Rather than asserting the usage of GroupMember.Read.All over Group.Read.All I think it would be preferable to add a note explaining why GroupMember.Read.All can be used in place of Group.Read.All

I think it is important that people should use the lower privileged permissions and not only can use them. Also Microsoft themself recommends the GroupMember permission as least-privileged permissions (See here for the used endpoint.

I'll think how to better phrase that, if you wish to leave the Group permission in the documentation.

@mtesauro
Copy link
Copy Markdown
Contributor

mtesauro commented Dec 3, 2025

@dcfSec While I also agree that people should use the least privileged option (and we should highlight that as the preferred option), I also believe the docs should reflect all the options, noting which are better than others rather than excluding less optimal options.

I've been doing this security stuff long enough to know sometimes circumstances forces the best of the bad options vs the truly best option from time to time.

I'd rather have our users informed and able to make the choice that best fits their situation which they'll know best.

@dcfSec dcfSec closed this by deleting the head repository Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants