reimplement favicons, update theme#13502
Merged
mtesauro merged 7 commits intoDefectDojo:bugfixfrom Oct 26, 2025
Merged
Conversation
Maffooch
requested changes
Oct 23, 2025
Contributor
Maffooch
left a comment
Maffooch
left a comment
There was a problem hiding this comment.
Will need to update Hugo version in a few places:
django-DefectDojo/.github/workflows/validate_docs_build.yml
Lines 15 to 16 in e31214a
django-DefectDojo/.github/workflows/gh-pages.yml
Lines 18 to 19 in e31214a
Maffooch
approved these changes
Oct 23, 2025
Contributor
There was a problem hiding this comment.
@paulOsinski dont forget to link the PR in the description
valentijnscholten
approved these changes
Oct 23, 2025
blakeaowens
approved these changes
Oct 24, 2025
1 task
Maffooch
pushed a commit
to valentijnscholten/django-DefectDojo
that referenced
this pull request
Feb 16, 2026
* update package & package-lock * rename directories for hugo 0.152.1 * update other stuff * replace favicons * Update validate_docs_build.yml * Update gh-pages.yml --------- Co-authored-by: Paul Osinski <paul.m.osinski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR requires that we upgrade our Hugo to v0.152.1. These are breaking changes and our site will not build without that upgrade.
This upgrades our documentation to use v1.8 of Doks, our theme, which I followed according to their documentation: https://getdoks.org/docs/upgrade/guides/doks-v1.8/
I can confirm this means Favicons work, and the site builds as long as you're using the latest version of Hugo. Favicons do not go in the
../static/faviconsfolder anymore, they live in../assetsand one of the plugins here will automatically create the required favicons when you run in production.[sc-11968]