Skip to content

Similar Findings: Restrict to Product Scope#13271

Merged
Maffooch merged 4 commits intodevfrom
similar-finding-product-scope
Oct 2, 2025
Merged

Similar Findings: Restrict to Product Scope#13271
Maffooch merged 4 commits intodevfrom
similar-finding-product-scope

Conversation

@Maffooch
Copy link
Copy Markdown
Contributor

The similar finding table allows for manually setting duplicates of findings that deduplication did not fully catch. This is a neat feature, but it also allowed for findings to be a duplicate of a finding from a different product entirely. This not something a naturally occurring circumstance in deduplication, so we should not allow it in similar findings either

@Maffooch Maffooch requested a review from mtesauro as a code owner September 26, 2025 21:07
@github-actions github-actions Bot added the ui label Sep 26, 2025
Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Comment thread dojo/templates/dojo/view_finding.html Outdated
@valentijnscholten valentijnscholten added this to the 2.51.0 milestone Sep 29, 2025
Co-authored-by: valentijnscholten <valentijnscholten@gmail.com>
Comment thread dojo/templates/dojo/view_finding.html Outdated
@Maffooch Maffooch merged commit 22d7ece into dev Oct 2, 2025
90 checks passed
@Maffooch Maffooch deleted the similar-finding-product-scope branch October 21, 2025 20:39
Maffooch added a commit to valentijnscholten/django-DefectDojo that referenced this pull request Feb 16, 2026
* Similar Findings: Restrict to Product Scope

* fix data tables oops

* Update dojo/templates/dojo/view_finding.html

Co-authored-by: valentijnscholten <valentijnscholten@gmail.com>

* Update dojo/templates/dojo/view_finding.html

---------

Co-authored-by: valentijnscholten <valentijnscholten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants