Skip to content

feat(social): Add SOCIAL_AUTH_OIDC_LOGIN_BUTTON_TEXT#13150

Merged
valentijnscholten merged 1 commit intoDefectDojo:bugfixfrom
kiblik:add_SOCIAL_AUTH_OIDC_LOGIN_BUTTON_TEXT
Sep 11, 2025
Merged

feat(social): Add SOCIAL_AUTH_OIDC_LOGIN_BUTTON_TEXT#13150
valentijnscholten merged 1 commit intoDefectDojo:bugfixfrom
kiblik:add_SOCIAL_AUTH_OIDC_LOGIN_BUTTON_TEXT

Conversation

@kiblik
Copy link
Copy Markdown
Contributor

@kiblik kiblik commented Sep 10, 2025

SAML and KEYCLOAK already had a customizable button label. Why not OIDC?

I was thinking about customization of others as well, but none of them can run as a standalone instance (only SAML, KEYCLOACK, and OIDC).

@github-actions github-actions Bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs ui labels Sep 10, 2025
@dryrunsecurity
Copy link
Copy Markdown

DryRun Security

This pull request contains an open redirect vulnerability: the OIDC login URL uses the user-controlled GET parameter request.GET.next directly in dojo/templates/dojo/login.html (lines 49–55) with no visible client-side validation. The scanner could not inspect server-side code/config, so no backend mitigation could be confirmed and the issue is considered confirmed.

Open Redirect in dojo/templates/dojo/login.html
Vulnerability Open Redirect
Description The 'next' parameter in the OIDC login URL is directly populated from the user-controlled GET parameter 'request.GET.next' without any visible client-side validation or sanitization. Due to persistent tool limitations preventing access to server-side code and configuration files, it was not possible to verify if any backend validation or mitigation for open redirects is in place. Therefore, based on the direct use of unvalidated user input in a redirect URL, the vulnerability is considered confirmed.

<div class="form-group">
{% if OIDC_ENABLED is True %}
<div class="col-sm-offset-1 col-sm-2">
<a href="{% url 'social:begin' 'oidc' %}?next={{ request.GET.next }}" style="color: rgb(255, 255, 255)" class="btn btn-success" type="button">{{ SOCIAL_AUTH_OIDC_LOGIN_BUTTON_TEXT }}</a>
</div>
{% endif %}


All finding details can be found in the DryRun Security Dashboard.

@valentijnscholten valentijnscholten merged commit 976f72c into DefectDojo:bugfix Sep 11, 2025
84 checks passed
@kiblik kiblik deleted the add_SOCIAL_AUTH_OIDC_LOGIN_BUTTON_TEXT branch September 11, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants