feat(social): Add SOCIAL_AUTH_OIDC_LOGIN_BUTTON_TEXT#13150
Merged
valentijnscholten merged 1 commit intoDefectDojo:bugfixfrom Sep 11, 2025
Merged
Conversation
|
This pull request contains an open redirect vulnerability: the OIDC login URL uses the user-controlled GET parameter request.GET.next directly in dojo/templates/dojo/login.html (lines 49–55) with no visible client-side validation. The scanner could not inspect server-side code/config, so no backend mitigation could be confirmed and the issue is considered confirmed.
Open Redirect in
|
| Vulnerability | Open Redirect |
|---|---|
| Description | The 'next' parameter in the OIDC login URL is directly populated from the user-controlled GET parameter 'request.GET.next' without any visible client-side validation or sanitization. Due to persistent tool limitations preventing access to server-side code and configuration files, it was not possible to verify if any backend validation or mitigation for open redirects is in place. Therefore, based on the direct use of unvalidated user input in a redirect URL, the vulnerability is considered confirmed. |
django-DefectDojo/dojo/templates/dojo/login.html
Lines 49 to 55 in 35ccc61
All finding details can be found in the DryRun Security Dashboard.
Maffooch
approved these changes
Sep 10, 2025
blakeaowens
approved these changes
Sep 10, 2025
paulOsinski
approved these changes
Sep 11, 2025
valentijnscholten
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAML and KEYCLOAK already had a customizable button label. Why not OIDC?
I was thinking about customization of others as well, but none of them can run as a standalone instance (only SAML, KEYCLOACK, and OIDC).