Skip to content

docker: remove dev dependencies from release images#13095

Merged
valentijnscholten merged 2 commits intoDefectDojo:devfrom
valentijnscholten:split-dev-dependencies
Sep 10, 2025
Merged

docker: remove dev dependencies from release images#13095
valentijnscholten merged 2 commits intoDefectDojo:devfrom
valentijnscholten:split-dev-dependencies

Conversation

@valentijnscholten
Copy link
Copy Markdown
Member

@valentijnscholten valentijnscholten commented Sep 2, 2025

I wasn't going to spend time on this, but then Cursor AI got it right almost on the first go.

Some dependencies are only needed for development, we shouldn't install those in the release ("production") images.

@github-actions github-actions Bot added docker settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs labels Sep 2, 2025
@valentijnscholten valentijnscholten changed the base branch from bugfix to dev September 2, 2025 17:54
@github-actions github-actions Bot removed settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs labels Sep 2, 2025
@valentijnscholten valentijnscholten marked this pull request as ready for review September 2, 2025 17:55
@valentijnscholten valentijnscholten modified the milestones: 2.51.1, 2.51.0 Sep 2, 2025
Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro
Copy link
Copy Markdown
Contributor

mtesauro commented Sep 2, 2025

Did you consider doing the same for for the Debian dockerfile?
https://github.com/DefectDojo/django-DefectDojo/blob/master/Dockerfile.django-debian

@valentijnscholten
Copy link
Copy Markdown
Member Author

Did you consider doing the same for for the Debian dockerfile? https://github.com/DefectDojo/django-DefectDojo/blob/master/Dockerfile.django-debian

Yes, it's part of the PR or did I miss a part?

@mtesauro
Copy link
Copy Markdown
Contributor

mtesauro commented Sep 4, 2025

Did you consider doing the same for for the Debian dockerfile? https://github.com/DefectDojo/django-DefectDojo/blob/master/Dockerfile.django-debian

Yes, it's part of the PR or did I miss a part?

@valentijnscholten My bad. Been dealing with a bunch of family things lately and I guess I was tired when I looked at this before. I see that you did both so never mind my comment ☝️

@valentijnscholten valentijnscholten merged commit 74e28c3 into DefectDojo:dev Sep 10, 2025
84 checks passed
@fopina fopina mentioned this pull request Sep 17, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants