Implement NowSecure parser#13084
Closed
30vh1 wants to merge 8 commits intoDefectDojo:devfrom
Closed
Conversation
manuel-sommer
suggested changes
Sep 1, 2025
valentijnscholten
requested changes
Sep 1, 2025
Member
valentijnscholten
left a comment
valentijnscholten
left a comment
There was a problem hiding this comment.
Thank you for the PR! Left some comments to consider.
manuel-sommer
approved these changes
Sep 1, 2025
Contributor
manuel-sommer
left a comment
manuel-sommer
left a comment
There was a problem hiding this comment.
approved besides the recommencations from valentinscholten.
…es for resilience and modified unittests accordingly
valentijnscholten
requested changes
Sep 3, 2025
Member
valentijnscholten
left a comment
valentijnscholten
left a comment
There was a problem hiding this comment.
Please make all access to the json object safe using get()
…in favour of more resilient methods
Member
|
Thank you. Could you look at the failed tests? |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
|
Closing as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New parser for NowSecure app analysis results.
Test results
Tested basic parsing functionality for no vulns, one vuln and many vulns. Unittest added on the appropriate folder.
Documentation
Documentation has been updated on: documentation folder