feat(settings): Drop time_zone

[kiblik]

Drop support for time_zone in System settings

reason: #12974 (comment)

There are still some left calling of get_system_setting("time_zone"), but they will be dropped in #12995

[dryrunsecurity]

This pull request identifies a logic flaw in the sla_violated method where date comparisons might incorrectly report SLA violations due to comparing a DateTimeField with only the date component, potentially delaying the identification of expired SLAs.

Logic Flaw due to Date-Only Comparison in dojo/filters.py

Vulnerability

Logic Flaw due to Date-Only Comparison

Description

The sla_violated method uses Q(sla_expiration_date__lt=now().date()). If sla_expiration_date is a DateTimeField, this comparison will not correctly identify SLAs that expire on the current day. Any SLA expiring at any time on the current day will only be flagged as violated on the following day, as its DateTimeField value will not be strictly less than now().date() (which represents the beginning of the current day). This leads to a delay in reporting SLA violations.

django-DefectDojo/dojo/filters.py

Lines 222 to 228 in f618ae0

	risk_accepted=False,
	is_mitigated=False,
	mitigated=None,
	) & Q(sla_expiration_date__lt=now().date()),
	)
	options = {

---

All finding details can be found in the DryRun Security Dashboard.

[dogboat]

Only one small nit. Approving regardless, thank you!

[mtesauro]

Approved