Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-docker-images-for-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ jobs:
os: [alpine, debian]
platform: ["${{ inputs.platform }}"]
exclude:
- docker-image: nginx
os: debian
- docker-image: integration-tests
os: alpine
- docker-image: integration-tests
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
- name: Load docker images
timeout-minutes: 10
run: |-
docker load -i built-docker-image/nginx-${{ matrix.os }}-linux-amd64_img
docker load -i built-docker-image/nginx-alpine-linux-amd64_img
docker load -i built-docker-image/django-${{ matrix.os }}-linux-amd64_img
docker load -i built-docker-image/integration-tests-debian-linux-amd64_img
docker images
Expand All @@ -73,14 +73,14 @@ jobs:
run: docker compose up --no-deps -d postgres nginx celerybeat celeryworker mailhog uwsgi redis
env:
DJANGO_VERSION: ${{ matrix.os }}
NGINX_VERSION: ${{ matrix.os }}
NGINX_VERSION: alpine

- name: Initialize
timeout-minutes: 10
run: docker compose up --no-deps --exit-code-from initializer initializer
env:
DJANGO_VERSION: ${{ matrix.os }}
NGINX_VERSION: ${{ matrix.os }}
NGINX_VERSION: alpine

- name: Integration tests
timeout-minutes: 10
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/k8s-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,10 @@ jobs:
timeout-minutes: 15
run: |-
eval $(minikube docker-env)
docker load -i built-docker-image/nginx-${{ matrix.os }}-linux-amd64_img
docker load -i built-docker-image/nginx-alpine-linux-amd64_img
docker load -i built-docker-image/django-${{ matrix.os }}-linux-amd64_img
docker tag defectdojo/defectdojo-nginx:alpine defectdojo/defectdojo-nginx:latest
docker tag defectdojo/defectdojo-django:${{ matrix.os }} defectdojo/defectdojo-django:latest
docker images

- name: Configure HELM repos
Expand Down Expand Up @@ -87,8 +89,7 @@ jobs:
--set initializer.keepSeconds="-1" \
${{ env[matrix.databases] }} \
${{ env[matrix.brokers] }} \
--set createSecret=true \
--set tag=${{ matrix.os }}
--set createSecret=true

- name: Check deployment status
if: always()
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/release-x-manual-docker-containers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ jobs:
matrix:
docker-image: [django, nginx]
os: [alpine, debian]
exclude:
- docker-image: nginx
os: debian
Comment thread
mtesauro marked this conversation as resolved.
steps:
# Replace slashes so we can use this in filenames
- name: Set-platform
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ jobs:
matrix:
docker-image: [django, nginx]
os: [alpine, debian]

exclude:
- docker-image: nginx
os: debian
steps:
# deduce docker org name from git repo to make the build also work in forks
- id: Set-docker-org
Expand Down Expand Up @@ -69,14 +71,14 @@ jobs:

# debian images are the default / official ones, so these get the os-less tag
- name: Tag Debian with os-less tags
if: ${{ matrix.os == 'debian' }}
if: ${{ (matrix.docker-image == 'django' && matrix.os == 'debian') || (matrix.docker-image == 'nginx' && matrix.os == 'alpine') }}
working-directory: ${{ runner.temp }}/digests
run: |
set -x
docker buildx imagetools create -t "${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:${{ inputs.release_number }}" ${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:${{ inputs.release_number }}-${{ matrix.os }}

# just for logging
- name: Inspect default images
if: ${{ matrix.os == 'debian' }}
if: ${{ (matrix.docker-image == 'django' && matrix.os == 'debian') || (matrix.docker-image == 'nginx' && matrix.os == 'alpine') }}
run: |
docker buildx imagetools inspect ${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:${{ inputs.release_number }}
3 changes: 1 addition & 2 deletions .github/workflows/release-x-manual-tag-as-latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@e468171a9de216ec08956ac3ada2f0791b6bd435 # v3.11.1

# debian images are the default / official ones, and these were already tagged, so these get the latest tag
- name: Tag Debian with latest tags
- name: Tag with latest tags
run: |
set -x
docker buildx imagetools create -t "${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:latest" ${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:${{ inputs.release_number }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/rest-framework-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ jobs:
- name: Load docker images
timeout-minutes: 10
run: |-
docker load -i built-docker-image/nginx-${{ matrix.os }}-${{ env.PLATFORM }}_img
docker load -i built-docker-image/django-${{ matrix.os }}-${{ env.PLATFORM }}_img
docker images

Expand Down
101 changes: 0 additions & 101 deletions Dockerfile.nginx-debian

This file was deleted.

2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ services:
nginx:
build:
context: ./
dockerfile: "Dockerfile.nginx-${DEFECT_DOJO_OS:-debian}"
dockerfile: "Dockerfile.nginx-alpine"
image: "defectdojo/defectdojo-nginx:${NGINX_VERSION:-latest}"
depends_on:
uwsgi:
Expand Down