feat(helm): Improve docs, add schema#12984
Conversation
6583e5c to
f1d0fec
Compare
45a7e4a to
76c5147
Compare
76c5147 to
50d874e
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
50d874e to
81672bb
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
5be90c1 to
36363b5
Compare
|
@fernandezcuesta, I was planning to autogenerate However, I bumped into the following issue: I know that I would be able to forcefully patch related places with |
|
Hi, I guess it's gonna be easier to set those 3 to an empty string rather than |
36363b5 to
50c019e
Compare
Ok, it looks like I made so silly typo when I was testing it before because now it works perfectly. |
7b109ed to
564c3d1
Compare
564c3d1 to
9ed055d
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
9ed055d to
cf73e1c
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
* feat(helm): Improve docs, add schema * Swap helm/defectdojo/README.md & readme-docs/KUBERNETES.md
readme-docs/KUBERNETES.mdwas replaced with a simple description where the information can be foundREADME.md/KUBERNETES.mdwas removed, onlyREADME.md.gotmpl)values.schema.json- this is useful for values validation before manifests are sent to the k8s APIvalues.yamlbut did not mention it in the documentation, GHA will fail)There is still a huge place for improvement (render comments from
values.yamlto descriptions, add$reffor better validation of k8s resources, mention all available variables, addno-additional-properties, ...). Still, it is a good second step (the first was definitely #12691) for improving the helm chart.