perf2: skip post processing if not needed#12862
Merged
valentijnscholten merged 14 commits intoDefectDojo:bugfixfrom Jul 31, 2025
Merged
perf2: skip post processing if not needed#12862valentijnscholten merged 14 commits intoDefectDojo:bugfixfrom
valentijnscholten merged 14 commits intoDefectDojo:bugfixfrom
Conversation
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
Maffooch
approved these changes
Jul 28, 2025
dogboat
approved these changes
Jul 29, 2025
blakeaowens
approved these changes
Jul 30, 2025
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
valentijnscholten
force-pushed
the
product-grade-skip-in-save
branch
from
eb6f430 to
3858ea3
Compare
github-actions
Bot
added
docker
New Migration
valentijnscholten
force-pushed
the
product-grade-skip-in-save
branch
from
0a7c486 to
3858ea3
Compare
github-actions
Bot
removed
docker
New Migration
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There'll be a sequence of import performance related PRs. They are separated into small PRs to simplify review and troubleshooting. As they all use
test_importers_performance, they'll build on eachother. So they'll have to be merged by natural ordering.The
finding.save()method creates an async task to postprocess the finding even if it's not needed. This is mainly of importance if product grading is disabled. In that case post processing is not needed, so we shouldn't create a celery task.The celery task would exit quite fast, but still it would incur cpu cycles, redis cycles and at least 1 database query.
Let's save some trees and possibly some cost.