Skip to content

Async Delete: Correct instances of multiple audit log entries for delete#12650

Merged
valentijnscholten merged 5 commits intobugfixfrom
Maffooch-patch-2
Jun 27, 2025
Merged

Async Delete: Correct instances of multiple audit log entries for delete#12650
valentijnscholten merged 5 commits intobugfixfrom
Maffooch-patch-2

Conversation

@Maffooch
Copy link
Copy Markdown
Contributor

Correcting the following:

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/celery/app/trace.py", line 453, in trace_task
    R = retval = fun(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/celery/app/trace.py", line 736, in __protected_call__
    return self.run(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/dojo/utils.py", line 2331, in delete_chunk
    obj.delete()
  File "/app/dojo/models.py", line 1614, in delete
    super().delete(*args, **kwargs)
  File "/usr/local/lib/python3.11/site-packages/django/db/models/base.py", line 1273, in delete
    return collector.delete()
           ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/deletion.py", line 508, in delete
    signals.post_delete.send(
  File "/usr/local/lib/python3.11/site-packages/django/dispatch/dispatcher.py", line 189, in send
    response = receiver(signal=self, sender=sender, **named)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/dojo/engagement/signals.py", line 43, in engagement_post_delete
    le = LogEntry.objects.get(
         ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/manager.py", line 87, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/query.py", line 652, in get
    raise self.model.MultipleObjectsReturned(
auditlog.models.LogEntry.MultipleObjectsReturned: get() returned more than one LogEntry -- it returned 2!

@Maffooch Maffooch requested a review from mtesauro as a code owner June 21, 2025 01:20
@dryrunsecurity
Copy link
Copy Markdown

DryRun Security

No security concerns detected in this pull request.


All finding details can be found in the DryRun Security Dashboard.

Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Comment thread dojo/utils.py
Comment thread dojo/endpoint/signals.py
@valentijnscholten valentijnscholten merged commit b769410 into bugfix Jun 27, 2025
140 of 142 checks passed
@Maffooch Maffooch deleted the Maffooch-patch-2 branch October 21, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants