Repository navigation
Update math/resize - #406
Merged
Merged
Conversation
mirjagranfors
marked this pull request as ready for review
August 11, 2025 12:47
Pwhsky
approved these changes
Aug 15, 2025
| self.assertEqual(resized.shape, (4, 8)) | ||
|
|
||
| ### Test with PyTorch tensor (if available) | ||
| if TORCH_AVAILABLE: |
Collaborator
There was a problem hiding this comment.
The unit tests look good, I think we should separate the torch and numpy cases by putting them in either the TestMath_Numpy or TestMath_Torch classes, since they provide the BACKEND flag in the first line which makes it easily readable, like I did in PR #407
Collaborator
Author
There was a problem hiding this comment.
Yes, I agree. But maybe it is easiest to do the entire test_math.py like that in a separate PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated docs of math/resize.
Made it compatible with torch, with a focus on getting the same results regardless if the input is a numpy array or a torch tensor.
Updated the unittesting, and included tests for torch