Skip to content

Features: Store - #397

Merged
giovannivolpe merged 227 commits into
developfrom
JH/functions/feature_Store
Sep 5, 2025
Merged

giovannivolpe merged 227 commits into
developfrom
JH/functions/feature_Store

Conversation

@JChonpca

@JChonpca JChonpca commented Jul 28, 2025 •

Copy link
Copy Markdown
Collaborator

unittest, torch compatible, docs

giovannivolpe and others added 15 commits July 11, 2025 13:46
* add docs of  /features/__rle__

* u

* u

* Update features.py

---------

Co-authored-by: Jiacheng Huang <chonpcaacpnohc@gmail.com>
Co-authored-by: Giovanni Volpe <46021832+giovannivolpe@users.noreply.github.com>
Co-authored-by: Jiacheng Huang <chonpcaacpnohc@gmail.com>
* add docs 0f /features/__rge__

* u

* u

* right ,

* Update features.py

---------

Co-authored-by: Jiacheng Huang <chonpcaacpnohc@gmail.com>
Co-authored-by: Giovanni Volpe <46021832+giovannivolpe@users.noreply.github.com>
* add docs of /features/__xor__

* remove blank spaces

---------

Co-authored-by: Jiacheng Huang <chonpcaacpnohc@gmail.com>
* add docs of /features/__rand__

* Update features.py

---------

Co-authored-by: Jiacheng Huang <chonpcaacpnohc@gmail.com>
Co-authored-by: Giovanni Volpe <46021832+giovannivolpe@users.noreply.github.com>
Co-authored-by: Jiacheng Huang <chonpcaacpnohc@gmail.com>
@JChonpca
JChonpca requested review from Pwhsky and mirjagranfors July 28, 2025 06:21
Jiacheng Huang added 2 commits July 28, 2025 09:25
@JChonpca JChonpca changed the title Update /features/store Features: Store Jul 28, 2025

@mirjagranfors mirjagranfors left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I made a few minor changes.

I don't really understand why there are changes in the DTAT391B_sources.folder tutorial in this PR, but I also don't think that it matters, since you haven't changed any of the content of the tutorial.

@JChonpca

JChonpca commented Jul 29, 2025 •

Copy link
Copy Markdown
Collaborator Author

Thanks for the review from @mirjagranfors.

For the difference in the DTAT391B_sources.folder tutorial, I have no idea about it. I did not get a conflict notification when I merged the Develop branch to this branch in the latest. I will merge once again to see what will happen (Nothing happened).

This will also appear in #400. But please ignore it in final merge

@JChonpca
JChonpca requested a review from giovannivolpe July 31, 2025 12:23
@giovannivolpe
giovannivolpe merged commit 6a3df3d into develop Sep 5, 2025
25 checks passed
@giovannivolpe
giovannivolpe deleted the JH/functions/feature_Store branch September 5, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants