security: fix 10 critical CVEs in Go deps and toolchain - #233
Merged
Conversation
Resolves all 10 critical advisories flagged for globstar in the Jul-2026 dependency scan: - golang.org/x/crypto v0.35.0 -> v0.54.0 (CVE-2026-46595 + 39833/39832/ 39830/39831/39834 + 42508 -- 7 ssh CVEs, fixed 0.52.0) - golang.org/x/net v0.35.0 -> v0.57.0 (CVE-2026-39821, fixed 0.55.0) - toolchain go 1.23.2 -> go1.25.12 (CVE-2025-22871 @1.24.2, CVE-2025-68121 @1.25.7) golang.org/x/sys is pulled to v0.47.0 as required by x/crypto and x/net. CI go-version bumped 1.23 -> 1.25 to match the toolchain. Targets match the 0.54.0 / 0.57.0 set also used across marvin/coat, which is OSV-clean and clears newer moderate advisories too. All resolved versions OSV-clean; x/crypto's only residual is the openpgp unmaintained notice (GO-2026-5932), which globstar does not import. Verified: registry gen + test suite 5 ok/0 FAIL (== master baseline), make build, and an end-to-end analyzer run (72 files, correct diagnostics).
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
sourya-deepsource
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all 10 critical SCA advisories flagged for globstar in the Jul-2026 scan. globstar doesn't depend on
artifactsor grpc, so this is a direct dep + toolchain bump. Fixed versions cross-checked against OSV.dev, and every resolved version re-scanned to confirm it isn't in a newer advisory window.Changes (all required, nothing gratuitous)
golang.org/x/cryptogolang.org/x/netgolang.org/x/sysgo 1.23.2→go 1.25.0+toolchain go1.25.12build-and-test.yaml,release.yml)go-version: 1.23→1.25go.mod: 0 packages added, 0 removed — only the version changes above. x/crypto/x-net/x-sys are all indirect and not imported by globstar's code (no API surface touched); the only behavioral-risk change is the toolchain bump, gated by the tests + e2e below.The one residual — unfixable by bump (suppress-only)
¹
x/cryptoGO-2026-5932 —openpgppackage unmaintained (informational). Affects all versions;openpgpis not imported anywhere in globstar → not reachable.Verification
5 ok / 0 FAIL; after the bump the identical suite is5 ok / 0 FAIL(matched exactly). (Preflight:make generate-registry— the generatedAnalyzerRegistryis required to build/test.)make build→bin/globstarproduced.