Skip to content

Additional weekly CI fixes & improvements - #249

Merged
C-Achard merged 8 commits into
mainfrom
cy/weekly-ci-fixes
Sep 21, 2026
Merged

C-Achard merged 8 commits into
mainfrom
cy/weekly-ci-fixes

Conversation

@C-Achard

@C-Achard C-Achard commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator
  • Fixed the current failure by running tests against the installed wheel rather than src/
  • Removed the now redundant "force-deploy" manual dispatch flow
    • Now that we can manually dispatch checks it is no longer relevant
  • Improved weekly check issue body and workflow
    • Added force fail arg for testing
    • Improved instructions for closing
  • Trimmed some workflow comments

Closes #248


  • Run both force-fail and regular weekly check manually for this branch
  • Run weekly checks manually on main after merging

Separate wheel installation from the headless GUI test step in the release workflow. The wheel is installed and a temporary test directory is created first, then pytest runs from that directory via the action's `working-directory` and `shell` settings so the shipped wheel tests run against the installed package instead of the source tree.
Remove the manual `force_deploy` workflow input and simplify the release conditions so the build and deploy jobs only run for `v*` tags. This prevents manual dispatches from attempting package publication from untagged commits, which would fail because PyPI rejects the local versions generated by `setuptools_scm`.
Expand the weekly checks failure issue workflow to include per-job results, clearer run links, and step-by-step recovery guidance. New issues are now assigned to the regular maintainers, while repeated failures are added as comments with the latest status summary.
Allow manual runs of the weekly checks workflow to simulate a failure and exercise the notification path. This skips the real reusable jobs, adds a dedicated failing job, and updates the notify logic and issue content so test runs create clearly labeled tracking issues instead of waiting for a real scheduled failure.
Use explicit environment variables and a unique multiline output delimiter when collecting changed files, and check out the pull request head repository in the pre-commit job. This makes the formatting workflow more reliable for pull requests, including ones from forks.
@C-Achard C-Achard self-assigned this Sep 21, 2026
@C-Achard C-Achard added enhancement New feature or request bug fix Fixes an issue or a bug CI Related to CI/CD and workflows labels Sep 21, 2026
@C-Achard
C-Achard requested a balanced review from Copilot September 21, 2026 07:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved CI correctness issues can cause checks to test code other than the intended revision or installed wheel.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)
What changed in this PR

Improves weekly CI reliability, release testing, and failure notifications.

Changes:

  • Adds simulated weekly failures and richer tracking issues.
  • Removes redundant forced deployment.
  • Improves wheel and pull-request workflow handling.
File Description
.github/​workflows/​weekly_checks.yml Adds notification testing and detailed issue reporting.
.github/​workflows/​test_and_deploy.yml Removes forced deployment and simplifies tag gating.
.github/​workflows/​format.yml Improves changed-file handling and fork checkout support.
.github/​workflows/​build_release.yml Separates wheel installation from installed-package tests.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/build_release.yml
Comment thread .github/workflows/format.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@C-Achard
C-Achard requested a review from deruyter92 September 21, 2026 07:25
@C-Achard
C-Achard marked this pull request as ready for review September 21, 2026 07:25
@C-Achard C-Achard mentioned this pull request Sep 21, 2026
@C-Achard
C-Achard merged commit 18b527c into main Sep 21, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix Fixes an issue or a bug CI Related to CI/CD and workflows enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weekly checks failing

3 participants