# 48 ResNet 모델과 typo 수정 - #49
Open
Ronalmoo wants to merge 44 commits into
Open
Conversation
* Repository hierarchy reconstructed * Add binarylinear
[JH/Weight Histogram Visualization] MNIST `nn.module`에서 weights 추출하기; Colab - 5 days DeepBaksuVision#29 +
# Conflicts: # dataloader/data_loader.py # train.py
This reverts commit 142794d.
ssaru
requested changes
Nov 19, 2019
ssaru
left a comment
ssaru
left a comment
Contributor
There was a problem hiding this comment.
코드 리뷰 완료하였습니다.
ResNet은 어디서 코드를 가져오셨나요?
| @@ -21,4 +22,4 @@ def data_loader(dataset="CIFAR-10", batch_size = 16): | |||
| test_loader = torch.utils.data.DataLoader(test_set, batch_size=batch_size, shuffle=False, num_workers=2) | |||
| classes = ("0", "1", "2", "3", "4", "5", "6", "7", "8", "9") | |||
Contributor
There was a problem hiding this comment.
CIFAR-10인데 classes = ("0", "1", "2", "3", "4", "5", "6", "7", "8", "9")은 무엇일까요?
Comment on lines
+12
to
+14
| def conv3x3(in_channels, out_channels, stride=1): | ||
| return nn.Conv2d(in_channels, out_channels, kernel_size=3, stride=stride, | ||
| padding=1, bias=False) |
Contributor
There was a problem hiding this comment.
그냥 호불호인데 이렇게까지 분리 안해도 될 거 같긴한데.. ㅎㅎ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.