Skip to content

Minor fix to accommodate changes in scipy library and documentation update - #22

Merged
kdiers merged 7 commits into
mainfrom
dev
Jul 6, 2026
Merged

Minor fix to accommodate changes in scipy library and documentation update#22
kdiers merged 7 commits into
mainfrom
dev

Conversation

@kdiers

@kdiers kdiers commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Updates in Seam Computation:

  • Fixed array concatenation in getSeamCase1 and getSeamCase2 by ensuring that the result of st.mode is always at least 1D, preventing shape errors during concatenation.

QC Image Generation and Container Usage:

  • Added the --no-qc argument to both Docker and Singularity documentation, clarifying that QC image creation is not supported in these environments due to rendering issues.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Hipsta to better handle SciPy stats.mode output shape changes during seam computation, and clarifies/extends container usage documentation around disabling QC image generation.

Changes:

  • Make getSeamCase1/getSeamCase2 robust to scalar vs 1D stats.mode outputs during np.concatenate.
  • Respect --no-qc for the “hull” QC stage (consistent with existing “mesh” and “profile” gating).
  • Update Docker/Singularity docs (and tutorial wording) and bump package version/dependency constraints.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
VERSION Bumps package version to 0.10.1.
requirements.txt Updates SciPy dependency constraint.
hipsta/computeCubeParam.py Ensures stats.mode(...)[0] is at least 1D before concatenation in seam cases.
hipsta/utils/qc_plots.py Skips hull QC plot generation when --no-qc is set.
docker/Docker.md Documents --no-qc for container usage and adds note about QC limitations.
singularity/Singularity.md Documents --no-qc for container usage and adds note about QC limitations.
TUTORIAL.md Minor wording/grammar fixes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker/Docker.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@kdiers
kdiers marked this pull request as ready for review July 5, 2026 11:29
@kdiers
kdiers merged commit aaee652 into main Jul 6, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants