Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Hipsta to better handle SciPy stats.mode output shape changes during seam computation, and clarifies/extends container usage documentation around disabling QC image generation.
Changes:
- Make
getSeamCase1/getSeamCase2robust to scalar vs 1Dstats.modeoutputs duringnp.concatenate. - Respect
--no-qcfor the “hull” QC stage (consistent with existing “mesh” and “profile” gating). - Update Docker/Singularity docs (and tutorial wording) and bump package version/dependency constraints.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
VERSION |
Bumps package version to 0.10.1. |
requirements.txt |
Updates SciPy dependency constraint. |
hipsta/computeCubeParam.py |
Ensures stats.mode(...)[0] is at least 1D before concatenation in seam cases. |
hipsta/utils/qc_plots.py |
Skips hull QC plot generation when --no-qc is set. |
docker/Docker.md |
Documents --no-qc for container usage and adds note about QC limitations. |
singularity/Singularity.md |
Documents --no-qc for container usage and adds note about QC limitations. |
TUTORIAL.md |
Minor wording/grammar fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kdiers
marked this pull request as ready for review
July 5, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates in Seam Computation:
getSeamCase1andgetSeamCase2by ensuring that the result ofst.modeis always at least 1D, preventing shape errors during concatenation.QC Image Generation and Container Usage:
--no-qcargument to both Docker and Singularity documentation, clarifying that QC image creation is not supported in these environments due to rendering issues.