Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Hipsta’s atlas handling and processing pipeline to support additional Penn ABC-3T ASHS variants (including cortical areas), adds CLI options to resume processing from edited labels/masks, and performs general maintenance/cleanup (including additional debug/visualization outputs and minor documentation fixes).
Changes:
- Add two new built-in LUT variants (
ashs-penn_abc_3t_t2_ent,ashs-penn_abc_3t_t2_ext) and related boundary label support. - Introduce
--start-with-edited-labels/--start-with-edited-masksto resume processing from edited outputs. - Update cube parametrization / supplementary outputs (debug MGH outputs, seam logic simplification, additional orientation logic).
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| VERSION | Bump version to 0.9.2-dev. |
| TUTORIAL.md | Fix automask argument descriptions and correct y-dimension table content. |
| pyproject.toml | Adjust Ruff lint configuration (global E501 ignore). |
| hipsta/utils/create_supplementary_files.py | Add boundary overlay support for ashs-penn_abc_3t_t2_ext and refine overlay creation gating. |
| hipsta/removeBoundaryMask.py | Add MGH output for boundary removal visualization. |
| hipsta/processLabels.py | Extend automask logic to handle new LUT variants / additional labels. |
| hipsta/hipsta.py | Add new --lut keywords and new resume-from-edited CLI flags; adjust pipeline flow accordingly. |
| hipsta/doc/documentation.py | Minor whitespace/docstring formatting. |
| hipsta/doc/DOCUMENTATION.md | Document new CLI flags and update supported segmentation text (partially). |
| hipsta/cutTetra.py | Minor numeric array construction cleanup. |
| hipsta/createTetraLabels.py | Conditionally create additional boundary masks and update output naming. |
| hipsta/computeCubeParam.py | Remove newVtcsSgn logic; add LUT-specific orientation handling and extra debug outputs. |
| hipsta/cfg/config.py | Add defaults for new resume flags. |
| hipsta/cfg/atlases.py | Add atlas variants and bndba35 label. |
| .github/workflows/build.yml | Update CI Python matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
kdiers
marked this pull request as ready for review
June 24, 2026 12:49
kdiers
marked this pull request as draft
June 24, 2026 16:03
kdiers
marked this pull request as ready for review
June 24, 2026 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates and improvements across the codebase, focusing on bug fixes, documentation accuracy, new atlas support, enhanced editing options, and code simplification.
Atlas and Configuration Updates
ashs-penn_abc_3t_t2_entandashs-penn_abc_3t_t2_ext) inget_atlases, including their label/index mappings and associated region lists.bndba35) to the LUT dictionary for atlas configurations.Enhance editing options
start_with_edited_labelsandstart_with_edited_masksinget_defaults.Codebase Simplification and Cleanup
newVtcsSgnvariable and all related code from thegetSeamand its subfunctions incomputeCubeParam.py, simplifying the logic and return values.computeCubeParam.py.Documentation and Output Corrections