Skip to content

Fix CorpusCallosum NumPy 2.5 compatibility #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-reuter merged 3 commits into from
Jul 21, 2026
Merged

Fix CorpusCallosum NumPy 2.5 compatibility #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4600049
Fix CorpusCallosum NumPy 2 compatibility
karl-koschutnig Jul 9, 2026
9cc1cd2
Add tests for _requires_cross_sectional_passthrough function
karl-koschutnig Jul 15, 2026
dd1f9fe
Remove tests per review feedback
karl-koschutnig Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CorpusCallosum/shape/subsegment_contour.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,8 +880,8 @@ def transform_to_acpc_standard(
norms_product = np.linalg.norm(ac_pc_vec) * np.linalg.norm(posterior_vector)
theta = np.arccos(dot_product / norms_product)

# Determine the sign of the angle using cross product
cross_product = np.cross(ac_pc_vec, posterior_vector)
# Determine the sign of the angle using the signed z-component of the 2D cross product.
cross_product = ac_pc_vec[0] * posterior_vector[1] - ac_pc_vec[1] * posterior_vector[0]
if cross_product < 0:
theta = -theta

Expand Down
4 changes: 2 additions & 2 deletions CorpusCallosum/utils/mapping_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ def correct_nodding(ac_pt: Vector2d, pc_pt: Vector2d) -> AffineMatrix3x3:
norms_product = np.linalg.norm(ac_pc_vec) * np.linalg.norm(posterior_vector)
theta = np.arccos(dot_product / norms_product)

# Determine the sign of the angle using cross product
cross_product = np.cross(ac_pc_vec, posterior_vector)
# Determine the sign of the angle using the signed z-component of the 2D cross product.
cross_product = ac_pc_vec[0] * posterior_vector[1] - ac_pc_vec[1] * posterior_vector[0]
if cross_product < 0:
theta = -theta

Expand Down