fix(errors): surface the JSON error detail in REST error messages - #195
Merged
Conversation
tomershlasky
force-pushed
the
prompt-too-long-error-handling
branch
from
August 9, 2026 10:29
4a3e2f9 to
10cd962
Compare
commit: |
AdirAmsalem
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The API is adding server-side prompt validation: a prompt over the model's token limit is rejected with HTTP 400 and a JSON body like
{"detail": "Prompt is too long: ..."}. This PR makes that rejection (and any other JSON-detail error) read cleanly in SDK error messages.Changes
New
readErrorBody()helper inshared/request.ts, used byprocessand all threequeuerequest sites. Before:After:
Non-JSON bodies and JSON without a string
detailfall through to the raw text unchanged.Tests
processandqueue.submitwith a 400 JSON-detail body reject with the parsed message (msw). Full unit suite: 280 passed; biome clean.pnpm typecheckfails on main and on this branch with a pre-existing error inframe-metadata-diagnostics.ts(lookupFrameMetadatamissing onRemoteVideoTrack) — unrelated to this change.