Fix critical build-app and credit regressions#93
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Cole Collins <DealPatrol@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
/api/build-appswallowed AI generation and Git provider push failures, then still emitted a terminaldoneevent. Users could receive incomplete repositories while the UI reported success.userId, and shared credit deductions used a read-modify-write sequence that could overspend under concurrent requests.Root cause
Recent build launcher and billing changes reintroduced warning-only failure handling, placeholder generated files, body-scoped billing IDs, and non-atomic credit balance updates.
Fix
errorevents with nodone, throw on push failures, reject empty AI output, dedupe generated paths, create GitHub repos private, and charge/refund authenticated users around incomplete builds.getCurrentUser().idonly.Validation
pnpm exec eslint app/api/build-app/route.ts app/api/generate-scaffold/route.ts app/api/analyses/[id]/analyze/route.ts lib/credits.tspnpm exec tsc --noEmit/api/build-approute harness: verified success emitsdone, AI failure and push failure emit terminalerrorwith nodone, charged failures refund, insufficient credits stop before repo creation, duplicate README is pushed once, and GitHub repo payload is private.current_balance >= amountconditional update.