refactor(filter): use PolarInput#810
Open
dopenguin wants to merge 7 commits into
Open
Conversation
The differentiation between the interface for layout standard and nineRegions including the components KernCheckbox and KernBlockButtonCheckbox has been removed. This change includes a refactor of the store and its logic to work without much overhead together with PolarInput.
The differentiation between the interface for layout standard and nineRegions including the components KernRadioGroup and KernBlockButtonRadioGroup has been removed.
dopenguin
requested review from
czirkelbach,
oeninghe-dataport and
raschju
as code owners
|
# Conflicts: # src/plugins/filter/components/FilterCategory.ce.vue
# Conflicts: # src/components/kern/KernBlockButtonCheckbox.ce.vue # src/components/kern/KernBlockButtonRadioGroup.ce.vue # src/components/kern/KernRadioGroup.ce.vue # src/plugins/filter/stores/category.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces layout-conditional checkbox/radio components (
KernBlockButtonCheckbox,KernCheckbox,KernBlockButtonRadioGroup,KernRadioGroup) infilterwith the unifiedPolarInputcomponent (as proposed in #734).Simplifies
categorystatefromRecord<string, boolean>tostring[]and introduces a reactive getter/setter-basedselectionmodel on categories for directv-modelbinding and to get rid ofgetCategoryStatusandsetCategoryStatus.Also added some small changes to
PolarInputandPolarInputGroup.Instructions for local reproduction and review
npm run snowboxfilter1xxmulti-value category entry correctly selects/deselects with its individual values (100,101,102)Additional information
I intend to update the implementation in
src/plugins/filter/stores/category.ts(a) andsrc/plugins/filter/stores/time.ts(#811) as well.For (a): Currently, if a user switches between two layers, the filter state of the the previous layer is reset. This is odd from a usability perspective. If you agree, I'll change this in a separate PR so that the state stays even if the layer switches.
Tickets
Resolves #779