fix: usePluginStoreWatcher should support core store values#754
Open
oeninghe-dataport wants to merge 1 commit into
Open
fix: usePluginStoreWatcher should support core store values#754oeninghe-dataport wants to merge 1 commit into
oeninghe-dataport wants to merge 1 commit into
Conversation
oeninghe-dataport
requested review from
czirkelbach,
dopenguin,
raschju and
warm-coolguy
as code owners
|
oeninghe-dataport
force-pushed
the
fix/654-attributions-do-not-refresh-on-zoom
branch
from
8910367 to
ecfcb7c
Compare
dopenguin
requested changes
Jun 8, 2026
dopenguin
left a comment
dopenguin
left a comment
Member
There was a problem hiding this comment.
As the name of the composable suggests, the intended usage is for plugin values.
The name of the composable has to change or a second has to be added.
|
|
||
| const pluginIsInstalled = | ||
| source.plugin && coreStore.getPluginStore(source.plugin) | ||
| !source.plugin || coreStore.getPluginStore(source.plugin) |
Member
There was a problem hiding this comment.
This change seems unrelated to a coreStore value. If it is not, a variable named pluginIsInstalled should not be relevant for the coreStore and a different approach should be used here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bug occurs because
usePluginStoreWatcherdoes not support core store values yet.However,
zoomwhich is watched in snowbox configuration is a core store value.Instructions for local reproduction and review
See #654
Relevant tickets, issues, et cetera
Fixes #654