feat(gfi): migrate plugin#447
Open
oeninghe-dataport wants to merge 123 commits into
Open
Conversation
oeninghe-dataport
force-pushed
the
vue3/migrate-plugin-gfi
branch
3 times, most recently
from
58e73f6 to
f941649
Compare
oeninghe-dataport
force-pushed
the
vue3/migrate-plugin-gfi
branch
from
bb7336c to
6a3129e
Compare
|
The usually helpful variables (map, stores, etc.) are auto-exported as global variables for use with the browser's devtools in snowbox.
oeninghe-dataport
force-pushed
the
vue3/migrate-plugin-gfi
branch
from
acbf752 to
425cfdb
Compare
oeninghe-dataport
requested review from
dopenguin and
warm-coolguy
as code owners
# Conflicts: # examples/snowbox/services.js
dopenguin
requested changes
Feb 23, 2026
Member
There was a problem hiding this comment.
- Please add an example to
iceberg; this maybe should include an example with a layer where the feature list is not being used - There should be no horizontal scrollbar if no features are available
- Some things are missing / quite different with the featureList; some parts are connections with the markers feature. This includes:
- When hovering an element in the feature list, the feature is highlighted in the map with the hover style
- When hovering an element in the map, the feature is highlighted in the feature list (previously green); when hovering a clustered feature, all features that are part of the cluster are highlighted
- If I select a feature in the map, it is selected in the feature list
- If I select a feature in the feature list, the corresponding marker gets the selected style; currently, a yellow dot is being displayed
- If I select a feature in the feature list, the map should be centered on that feature
- If a feature is not selectable because of the configured
isSelectablefunction, it is not being shown in the feature list
The list may not be complete, so please take a look at Meldemichel regarding the various things mentioned above.
I'll be taking a look at the components and stores once you've tackled these things.
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
…eList Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Collaborator
Author
|
This allows for caching the texts generated by `getText`. It is primarily done for performance optimization.
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
As with the vue2 code, using a selectionDiff instead of doing a new selection is now the default. Besides that, we allow disabling that behaviour to stick with the current vue3 behaviour of using a new selection.
oeninghe-dataport
force-pushed
the
vue3/migrate-plugin-gfi
branch
from
d88da98 to
b760b14
Compare
Co-Authored-By: Pascal Röhling <pascal.roehling@dataport.de>
For the first two and last two pages, the selection of visible pages is adjusted to match the old behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the GFI plugin.
Instructions for local reproduction and review
Additional hints
requestGfi*were migrated as-is and do not need to be reviewed therefore.Relevant tickets, issues, et cetera
Closes #368