chore(deps): bump @babel/helpers and @babel/runtime 7→8 in /js#1449
Open
gcko wants to merge 2 commits into
Open
chore(deps): bump @babel/helpers and @babel/runtime 7→8 in /js#1449gcko wants to merge 2 commits into
gcko wants to merge 2 commits into
Conversation
Bump both major @babel packages together to avoid a mixed babel 7/8 runtime. @babel/helpers@8 requires node ^22.18 || >=24.11, so raise engines.node from >=24 to >=24.11 to keep the declared floor honest (CI uses setup-node@24 -> latest 24.x, local dev 24.13.0). Closes #1437 Closes #1438 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Jared Scott <jared.scott@datarecce.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Consolidates the two Dependabot major babel bumps into a single PR so they land together — splitting them would leave a mixed babel 7/8 runtime in the lockfile, which is unsupported. Both are direct dependencies in
js/package.json.@babel/helpers@babel/runtimeNode floor decision
@babel/helpers@8.0.0declaresengines.node: "^22.18.0 || >=24.11.0". The repo previously pinnedengines.node: ">=24", which would falsely permit node 24.0–24.10 — versions that do not satisfy helpers@8. To keep the declared floor honest, this PR raises:This is safe and changes nothing about what actually runs:
actions/setup-node@v4withnode-version: 24across all workflows (tests-js, tests-python, nightly, release, release-ui, address-dependabot), which resolves to the latest 24.x (currently ≥ 24.13) — already above the floor..nvmrcpins24.>=24intent) rather than re-opening node 22.Note:
@babel/runtime@8removed itsenginesfield entirely, so only@babel/helpers@8drives the floor.Incidental lockfile refresh
Regenerating the lockfile caught up 4 packages that were already within their existing caret ranges in
package.jsononmain(the lockfile was stale — nopackage.jsonrange changed):happy-dom20.10.5→20.10.6,import-in-the-middle3.0.2→3.1.0,posthog-js1.387.0→1.390.2,baseline-browser-mapping2.10.37→2.10.38.Verification (from
js/)pnpm installCI=true pnpm install --frozen-lockfilepnpm type:checkpnpm lint(biome)pnpm test(vitest)pnpm run build(next)No code changes were required for the major bump — babel 8 was a drop-in here.
PR Checklist
pnpm test, type:check, lint, build all green)User-facing changes
None. Internal dependency / build-tooling update only.
Closes #1437
Closes #1438