Configure Harbor registry for Docker builds - #7
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the Docker build infrastructure from local builds to Harbor registry (harbor.dataknife.net) for centralized image storage, and updates GitHub Actions workflows to use self-hosted runners with Harbor integration.
Key changes:
- Updated docker-compose.yml to pull pre-built images from Harbor instead of building locally
- Added Harbor-aware Makefile targets for login, push, and pull operations
- Modified GitHub Actions workflows to build and push to Harbor registry on non-PR events
- Added comprehensive Harbor setup documentation
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| docker-compose.yml | Replaced local build configuration with Harbor registry image references for both UI and API services |
| Makefile | Added Harbor registry variables and new targets (docker-login, docker-push, docker-pull) with environment variable validation |
| .github/workflows/docker.yml | Created new workflow for building and pushing Docker images to Harbor with metadata extraction and registry caching |
| .github/workflows/docker-build.yml | Updated existing workflow to use self-hosted runners, Harbor registry, and added Harbor login/push steps |
| .github/HARBOR_SETUP.md | Added comprehensive documentation for Harbor setup, including GitHub secrets configuration and local development instructions |
- GitLab CI: Use --password-stdin for secure Harbor login
- GitLab CI: Build once and tag instead of building twice
- GitLab CI: Replace deprecated 'only' with 'rules'
- Makefile: Use --password-stdin for docker-login (security)
- GitHub Actions: Standardize checkout action to v5
- GitHub Actions: Remove --force flag, use credential helper for git push
- GitHub Actions: Quote cache value ('npm')
- GitHub Actions: Fix multiline command formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR configures the repository to use Harbor registry for Docker image storage and updates GitHub Actions workflows to use self-hosted runners.
Changes
Harbor Registry
harbor.dataknife.net/library/high-command-uiGitHub Secrets Required
HARBOR_USERNAMEHARBOR_PASSWORDSecrets are already configured in the repository.