[python] skip test for APPSEC-61861#7313
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63972bd570
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/appsec/iast/sink/test_unvalidated_redirect.py::TestUnvalidatedHeader_ExtendedLocation: | ||
| - weblog_declaration: | ||
| "*": v4.12.0-rc1 (implemented in v3.9.0.dev) | ||
| "*": flaky (APPSEC-61861) # v4.7.0-rc1 (implemented in v3.9.0.dev, but there was the APPSEC-57817 and APPSEC-61861 bugs) |
There was a problem hiding this comment.
Preserve the pre-release missing-feature range
This wildcard flaky declaration applies to every Python version for every weblog. The previous v4.12.0-rc1 manifest entry was interpreted as missing_feature for versions below 4.12.0-rc1, so older tracer releases that do not implement this extended-location test are now reported/skipped as APPSEC-61861 flakes instead of missing features. Please keep a version-bounded missing-feature entry for the pre-implementation range, or bound the flaky marker to only the affected implemented versions.
Useful? React with 👍 / 👎.
Motivation
Related to the same unvalidated redirect flaky test https://datadoghq.atlassian.net/browse/APPSEC-61861
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present