Skip to content

[python] skip test for APPSEC-61861#7313

Merged
avara1986 merged 1 commit into
mainfrom
python_unvalidated_redirect_flaky
Jul 15, 2026
Merged

[python] skip test for APPSEC-61861#7313
avara1986 merged 1 commit into
mainfrom
python_unvalidated_redirect_flaky

Conversation

@avara1986

Copy link
Copy Markdown
Member

Motivation

Related to the same unvalidated redirect flaky test https://datadoghq.atlassian.net/browse/APPSEC-61861

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@avara1986 avara1986 added the python Pull requests that update Python code label Jul 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python

@avara1986 avara1986 marked this pull request as ready for review July 15, 2026 14:34
@avara1986 avara1986 requested review from a team as code owners July 15, 2026 14:34
@avara1986 avara1986 requested review from emmettbutler and florentinl and removed request for a team July 15, 2026 14:34

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63972bd570

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread manifests/python.yml
tests/appsec/iast/sink/test_unvalidated_redirect.py::TestUnvalidatedHeader_ExtendedLocation:
- weblog_declaration:
"*": v4.12.0-rc1 (implemented in v3.9.0.dev)
"*": flaky (APPSEC-61861) # v4.7.0-rc1 (implemented in v3.9.0.dev, but there was the APPSEC-57817 and APPSEC-61861 bugs)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the pre-release missing-feature range

This wildcard flaky declaration applies to every Python version for every weblog. The previous v4.12.0-rc1 manifest entry was interpreted as missing_feature for versions below 4.12.0-rc1, so older tracer releases that do not implement this extended-location test are now reported/skipped as APPSEC-61861 flakes instead of missing features. Please keep a version-bounded missing-feature entry for the pre-implementation range, or bound the flaky marker to only the affected implemented versions.

Useful? React with 👍 / 👎.

@avara1986 avara1986 merged commit 1652e2a into main Jul 15, 2026
51 checks passed
@avara1986 avara1986 deleted the python_unvalidated_redirect_flaky branch July 15, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants