Add retry for downloading install_script_agent#7310
Conversation
|
|
bric3
left a comment
There was a problem hiding this comment.
Pre-approving, but I agree having dedicated functions could be useful. The backoff with jitter might be useful as well.
|
The premise of the PR makes sense to me - retrying for the install step to make this step less error prone. The motivation however will not always be the case going forward:
I believe the FFE team are adding a mechanism to run system tests without an agent installed. I just want to call this out in case it interferes with the new system tests setup being worked on this week #7298 |
🎉 All green!🧪 All tests passed 🔗 Commit SHA: ff8bb35 | Docs | Datadog PR Page | Give us feedback! |
mhdatie
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing all the comments!
Motivation
dd-trace-javahas had multiple flaky failures recently due to the install_script_agent failing to download, likely due to flaky infra issues. e.g.Changes
Add a retry mechanism when pulling the install script. Fail if the script is not pulled - there's no point in continuing with the test if there's no agent installed.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present