Skip to content

Add retry for downloading install_script_agent#7310

Merged
sarahchen6 merged 6 commits into
mainfrom
sarahchen6/add-installer-script-download-retry
Jul 16, 2026
Merged

Add retry for downloading install_script_agent#7310
sarahchen6 merged 6 commits into
mainfrom
sarahchen6/add-installer-script-download-retry

Conversation

@sarahchen6

Copy link
Copy Markdown
Contributor

Motivation

dd-trace-java has had multiple flaky failures recently due to the install_script_agent failing to download, likely due to flaky infra issues. e.g.

Changes

Add a retry mechanism when pulling the install script. Fail if the script is not pulled - there's no point in continuing with the test if there's no agent installed.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/build/ssi/base/download_with_retry.sh                             @DataDog/system-tests-core
utils/build/ssi/base/base_ssi.Dockerfile                                @DataDog/system-tests-core
utils/build/ssi/base/base_ssi_installer.Dockerfile                      @DataDog/system-tests-core
utils/build/ssi/base/install_script_ssi.sh                              @DataDog/system-tests-core
utils/build/ssi/base/install_script_ssi_installer.sh                    @DataDog/system-tests-core

@sarahchen6 sarahchen6 marked this pull request as ready for review July 14, 2026 18:54
@sarahchen6 sarahchen6 requested a review from a team as a code owner July 14, 2026 18:54
Comment thread utils/build/ssi/base/install_script_ssi.sh
Comment thread utils/build/ssi/base/install_script_ssi.sh Outdated

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, but I agree having dedicated functions could be useful. The backoff with jitter might be useful as well.

Comment thread utils/build/ssi/base/install_script_ssi.sh Outdated
@mhdatie

mhdatie commented Jul 15, 2026

Copy link
Copy Markdown

The premise of the PR makes sense to me - retrying for the install step to make this step less error prone.

The motivation however will not always be the case going forward:

... - there's no point in continuing with the test if there's no agent installed.

I believe the FFE team are adding a mechanism to run system tests without an agent installed. I just want to call this out in case it interferes with the new system tests setup being worked on this week #7298

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 15, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ff8bb35 | Docs | Datadog PR Page | Give us feedback!

@mhdatie mhdatie left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing all the comments!

@sarahchen6 sarahchen6 merged commit 3a530b2 into main Jul 16, 2026
803 checks passed
@sarahchen6 sarahchen6 deleted the sarahchen6/add-installer-script-download-retry branch July 16, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants