feat: support osls 4#715
Open
stefan-person wants to merge 1 commit into
Open
Conversation
Use AWS SDK v3 for osls 4 and stick to v2 for the existing serverless or osls 3 case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support osls 4 and use AWS SDK v3 for osls 4 but stick to v2 for the existing serverless or osls 3 case
Motivation
We want to upgrade to osls 4 soon and the serverless-plugin-datadog is currently not supporting it. So I thought to give it a try
Testing Guidelines
Created a small test-lambda and deployed it once with osls 4 and once with osls 3. For both I get the log entries on datadog side for START, END and REPORT.
Additional Notes
To run the tests on my windows machine, I had to adjust the jest config a bit. It should now work for win and unix environment
Types of changes
Check all that apply