Skip to content

chore(deps): stop automatic updates for typify and schemars - #2290

Open
webern wants to merge 3 commits into
mainfrom
m/typify-issue
Open

chore(deps): stop automatic updates for typify and schemars#2290
webern wants to merge 3 commits into
mainfrom
m/typify-issue

Conversation

@webern

@webern webern commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Unfortunately there is a dependency deadlock with typify and schemars (we use typify to generate types from JSON-schema). This PR prevents rennovate from opening PRs that will not pass CI and that we cannot reasonably resolve in a bot-generated dependency-update PR.

Change Type

  • Non-functional (chore, refactoring, docs)

How did you test this PR?

N/A

References

The dependency issue is tracked in #2289

Keep schemars, typify, and prettyplease updates visible in the\nDependency Dashboard without opening automatic PRs while typify lacks\nschemars 1.0 support.
@webern
webern requested a review from a team as a code owner August 10, 2026 11:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc09dda06e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread renovate.json5
@pr-commenter

pr-commenter Bot commented Aug 10, 2026

Copy link
Copy Markdown

Binary Size Analysis (Agent Data Plane)

Baseline: f01ad23 · Comparison: 8adaa0c · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 41.64 MiB (baseline) vs 41.64 MiB (comparison)
Size Change: +8 B (+0.00%)

✅ Binary size difference within threshold

Changes by Module
Module File Size Symbols
anon.44a0faa3240fa409baa379409d152aec.1.llvm.16117383489013083859 +130 B 1
anon.44a0faa3240fa409baa379409d152aec.1.llvm.3898476927501213616 -129 B 1
anon.44a0faa3240fa409baa379409d152aec.4.llvm.16117383489013083859 +114 B 1
anon.44a0faa3240fa409baa379409d152aec.4.llvm.3898476927501213616 -113 B 1
anon.44a0faa3240fa409baa379409d152aec.3.llvm.16117383489013083859 +109 B 1
anon.44a0faa3240fa409baa379409d152aec.3.llvm.3898476927501213616 -108 B 1
anon.44a0faa3240fa409baa379409d152aec.0.llvm.16117383489013083859 +97 B 1
anon.44a0faa3240fa409baa379409d152aec.0.llvm.3898476927501213616 -96 B 1
anon.44a0faa3240fa409baa379409d152aec.2.llvm.16117383489013083859 +95 B 1
anon.44a0faa3240fa409baa379409d152aec.2.llvm.3898476927501213616 -94 B 1
[Unmapped] +3 B 1
Detailed Symbol Changes
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +130  [NEW]     +40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.16117383489013083859
  [NEW]    +114  [NEW]     +24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.16117383489013083859
  [NEW]    +109  [NEW]     +19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.16117383489013083859
  [NEW]     +97  [NEW]      +7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.16117383489013083859
  [NEW]     +95  [NEW]      +5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.16117383489013083859
  +8.1%      +3  [ = ]       0    [Unmapped]
  [DEL]     -94  [DEL]      -5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.3898476927501213616
  [DEL]     -96  [DEL]      -7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.3898476927501213616
  [DEL]    -108  [DEL]     -19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.3898476927501213616
  [DEL]    -113  [DEL]     -24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.3898476927501213616
  [DEL]    -129  [DEL]     -40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.3898476927501213616
  +0.0%      +8  [ = ]       0    TOTAL

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The approval rule matches the intended workspace dependencies while leaving unrelated Cargo and non-Cargo updates automatic. Renovate’s vulnerability-alert override still wins, so security fixes for these packages remain immediate rather than awaiting dashboard approval.

Was this helpful? React 👍 or 👎

📊 Validated against 10 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit fc09dda · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@pr-commenter

pr-commenter Bot commented Aug 10, 2026

Copy link
Copy Markdown

Regression Detector (Agent Data Plane)

Run ID: 638c594d-8688-4197-b8e3-87e90eb2632f
Baseline: f01ad238 · Comparison: dd3fb12c · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment goal Δ mean % links
quality_gates_rss_dsd_low memory ⚪ +0.27 metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory ⚪ +0.26 metrics profiles logs
quality_gates_rss_dsd_heavy memory ⚪ +0.06 metrics profiles logs
quality_gates_rss_dsd_medium memory ⚪ -0.11 metrics profiles logs
quality_gates_rss_idle memory ⚪ -0.21 metrics profiles logs
Bounds Checks: ✅ Passed (5)
experiment check replicates observed links
quality_gates_rss_dsd_heavy memory_usage 10/10 ✅ 228 MiB ≤ 250 MiB metrics profiles logs
quality_gates_rss_dsd_low memory_usage 10/10 ✅ 51.7 MiB ≤ 60 MiB metrics profiles logs
quality_gates_rss_dsd_medium memory_usage 10/10 ✅ 89.6 MiB ≤ 100 MiB metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 ✅ 383 MiB ≤ 420 MiB metrics profiles logs
quality_gates_rss_idle memory_usage 10/10 ✅ 32.1 MiB ≤ 40 MiB metrics profiles logs
Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

webern added 2 commits August 10, 2026 14:58
Give the blocked schema and code generation dependencies their own\nRenovate group so dashboard approval does not gate unrelated Cargo\nupdates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant