ci: forward BP_EXTERNAL_S3_URL explicitly on benchmark trigger#414
Open
igoragoli wants to merge 1 commit into
Open
ci: forward BP_EXTERNAL_S3_URL explicitly on benchmark trigger#414igoragoli wants to merge 1 commit into
igoragoli wants to merge 1 commit into
Conversation
Replace `forward: pipeline_variables: true` on the macrobenchmark child-pipeline trigger with an explicit `BP_EXTERNAL_S3_URL: $BP_EXTERNAL_S3_URL` passthrough. Forwarding all pipeline variables let a caller override sensitive child-pipeline settings (clone target, branch, region, cleanup); forwarding only the one variable we need closes that. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
🎯 Code Coverage (details) 🔗 Commit SHA: 5dec278 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
forward: pipeline_variables: trueon the macrobenchmark trigger with an explicitBP_EXTERNAL_S3_URL: $BP_EXTERNAL_S3_URLpassthrough.forward: pipeline_variables: truewas cleaner but passed every parent variable down to the child pipeline, which can be unsafe (a caller could override sensitive child settings such as the clone target, branch, region, or cleanup). OnlyBP_EXTERNAL_S3_URLis forwarded now, via the trigger job'svariables:block (defaultyaml_variablesforwarding). When an orchestrator leaves it unset, GitLab forwards the unexpanded literal$BP_EXTERNAL_S3_URL, which downstream code (bp-runner) treats as unset.Testing
This was tested when authoring DataDog/dd-trace-py#18955 on dd-trace-py. On that work, I tested the
BP_EXTERNAL_S3_URL: $BP_EXTERNAL_S3_URLexplicit forwarding behavior before switching toforward: pipeline_variables.