Avoid using __builtin_cpu_supports#505
Merged
Merged
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7d3104f | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
Pull request overview
This PR removes reliance on __builtin_cpu_supports for SSE4.1 detection in the glibc-compat ceilf implementation on __x86_64__, replacing it with a local cpuid-based runtime check to avoid problematic relocations / missing symbols in some toolchain + Rust linking scenarios.
Changes:
- Add a local
cpu_supports_sse41()helper that checks SSE4.1 support viacpuid. - Switch the
ceilfruntime dispatch to usecpu_supports_sse41()instead of__builtin_cpu_init()/__builtin_cpu_supports("sse4.1").
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dynamic Artifact Size Comparison 📦
Static Artifact Size Comparison 📦
|
cataphract
force-pushed
the
glopes/avoid-builtin-cpu-supports
branch
from
July 15, 2026 13:34
0079324 to
7d3104f
Compare
Anilm3
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.