Skip to content

Avoid exception in user resource comparison #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cataphract merged 1 commit into from
Jul 1, 2026
Merged

Avoid exception in user resource comparison #501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/user_resource.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,10 @@
#include "memory_resource.hpp"
#include <cstddef>
#include <stdexcept>
#include <typeinfo>

namespace ddwaf::memory {

class user_resource : public memory::memory_resource {
class user_resource final : public memory::memory_resource {
public:
using alloc_fn_type = void *(*)(void *, size_t, size_t);
using free_fn_type = void (*)(void *, void *, size_t, size_t);
Expand All @@ -27,6 +26,10 @@ class user_resource : public memory::memory_resource {
throw std::invalid_argument("undefined user alloc/free function");
}
}
user_resource(const user_resource &) = delete;
user_resource(user_resource &&) = delete;
user_resource &operator=(const user_resource &) = delete;
user_resource &operator=(user_resource &&) = delete;

~user_resource() override
{
Expand All @@ -50,12 +53,11 @@ class user_resource : public memory::memory_resource {
{
// Two memory_resources compare equal if and only if memory allocated from one
// memory_resource can be deallocated from the other and vice versa.
try {
const auto &user_mr = dynamic_cast<const user_resource &>(other);
return free_fn_ == user_mr.free_fn_;
} catch (const std::bad_cast &) {
const auto *user_mr = dynamic_cast<const user_resource *>(&other);
if (user_mr == nullptr) {
return false;
}
return free_fn_ == user_mr->free_fn_;
}

alloc_fn_type alloc_fn_;
Expand Down
Loading