-
Notifications
You must be signed in to change notification settings - Fork 21
fix(shared-runtime): make ForkSafeRuntime teardown structurally TLS/poison-safe #2220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+346
−34
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e5b9a90
fix(shared-runtime): guard shutdown() against Tokio TLS destruction d…
rachelyangdog ecd1886
fix(shared-runtime): port TLS shutdown guard to ForkSafeRuntime after…
rachelyangdog 1742952
style: rustfmt
rachelyangdog e85cc86
fix(shared-runtime): make ForkSafeRuntime teardown structurally TLS/p…
quinna-h 302c31d
fix(shared-runtime): flush workers from a helper thread when TLS is d…
quinna-h 0ab4490
fix(shared-runtime): scope lock_or_recover to terminal teardown only
mabdinur 0af3e0b
fix(shared-runtime): give MutexExt::lock_or_recover a default impl
mabdinur 8dd25ed
fix(shared-runtime): guard block_on against destroyed TLS via block_o…
mabdinur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PoisonError should not be used, we have no guarantee over the state in which the value was left.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I narrowed lock_or_recover to only the terminal teardown paths. Let me know if we should remove it all together (I can use parking_lot::Mutex instead)