-
Notifications
You must be signed in to change notification settings - Fork 21
feat(telemetry)!: Add Installation signature and AppProduct changes payloads #2213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,6 +51,9 @@ pub enum MetricNamespace { | |
| Telemetry, | ||
| Apm, | ||
| Sidecar, | ||
| Civisibility, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Because this enum uses Useful? React with 👍 / 👎. |
||
| Mlobs, | ||
| Ddtraceapi, | ||
| } | ||
|
|
||
| #[derive(Serialize, Deserialize, Debug, Clone, Copy, PartialEq, Eq, Hash)] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the default
telemetryfeature enabled, this newly added field is never initialized byTraceExporterBuilder::new(), so constructing the builder fails to compile (cargo check -p libdd-data-pipelinereports E0063 at theSelf { ... }initializer). Please addtelemetry_handle: Noneunder the same cfg gate innew()so the default data-pipeline build remains usable.Useful? React with 👍 / 👎.